Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cypress tests for hotkeys #42528

Closed
gikf opened this issue Jun 16, 2021 · 9 comments · Fixed by #43434
Closed

Adding cypress tests for hotkeys #42528

gikf opened this issue Jun 16, 2021 · 9 comments · Fixed by #43434
Labels
help wanted Open for all. You do not need permission to work on these. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc.

Comments

@gikf
Copy link
Member

gikf commented Jun 16, 2021

Issue for tracking adding cypress tests of hotkeys, as per #42503.

Challenges / Projects / Video challenges:

  • Navigation mode - 'escape'
  • Previous challenge - 'p'
  • Next challenge - 'n'
  • Focus on editor - 'e'
  • Focus on instructions panel - 'r'
  • Running the tests - 'ctrl + enter' / 'command + enter'
@gikf gikf added the platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. label Jun 16, 2021
@gikf gikf self-assigned this Jun 16, 2021
@Sembauke
Copy link
Member

Sembauke commented Aug 9, 2021

Hey @gikfk, Are you still planning on working on this?

@gikf
Copy link
Member Author

gikf commented Aug 9, 2021

Hey @Sembauke, sorry, I haven't managed to start on this yet. If you'd want feel free to have a go at it.

@Sembauke Sembauke added the help wanted Open for all. You do not need permission to work on these. label Aug 12, 2021
@lastrafda
Copy link

I would like to work on this @Sembauke

@Sembauke
Copy link
Member

Hey @lastrafda,
This is a pretty though one, let me know if you need some help.

@lastrafda
Copy link

lastrafda commented Aug 15, 2021

Thanks @Sembauke I'll let you know! In fact I do need some help
I was looking at a video challenge and I realized that you have to click inside the main tag or focus the "Check your answer" button in order to be able to use the previous challenge and next challenge hotkeys, is this the expected behavior?

@ShaunSHamilton
Copy link
Member

@lastrafda

you have to click inside the main tag or focus the "Check your answer" button in order to be able to use the previous challenge and next challenge hotkeys

Expected behaviour is using the esc key to allow the hotkeys to be targeted. That is, to enter navigation mode:

Navigation mode - 'escape'

@Sembauke
Copy link
Member

I've tested some of the hotkeys and the previous and next challenge hotkey does not seem to work for me. Can anyone test this out?

@gikf
Copy link
Member Author

gikf commented Sep 10, 2021

Any specific challenge type?

  • classic challenges: esc ->p and n works for current and challenges that are changed to
  • backend/project challenges: esc -> p and n works for current and challenges that are changed to
  • video challenges: click on page -> esc -> p and n works for current challenge, after changing challenge with hotkey, it's needed to click again on page to be able to use p or n

@ojeytonwilliams
Copy link
Contributor

video challenges: click on page -> esc -> p and n works for current challenge, after changing challenge with hotkey, it's needed to click again on page to be able to use p or n

Good catch @gikf I'll add a fix to Sem's PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants