Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable text in a table in Nigth Mode #51785

Closed
abomo opened this issue Oct 3, 2023 · 8 comments · Fixed by #51788
Closed

Unreadable text in a table in Nigth Mode #51785

abomo opened this issue Oct 3, 2023 · 8 comments · Fixed by #51788
Labels
help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: UI Threads for addressing UX changes and improvements to user interface type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@abomo
Copy link

abomo commented Oct 3, 2023

Describe the Issue

On the JavaScript Algorithms and Data Structures challlenge Escape Sequences in Strings
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings, a table doent display all the element in Nigth Mode.

Affected Page

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/escape-sequences-in-strings

Your code




;

Expected behavior

;

Screenshots

Dark mode
Ligth mode

System

  • Device: [e.g. iPhone 6, Laptop]
  • OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 22]

Additional context

No response

@abomo abomo added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. labels Oct 3, 2023
@naomi-lgbt
Copy link
Member

Thanks for reporting this.

We likely want to use the background-quarternary value here:

image

Maybe background-tertiary on light mode?

image

It looks like bootstrap is setting the styling for odd table rows.

@naomi-lgbt
Copy link
Member

so i request you to please assign this issue to me

Please stop and read our contributing guide.

https://contribute.freecodecamp.org/

This issue is not marked as ready for contributions or help wanted. Also, we do not assign issues.

@Prajwalr2003
Copy link

I apologize for my previous request to assign the issue. I understand and respect the project's guidelines as outlined in the contributing guide. I'll refrain from requesting issue assignment and will focus on issues marked as 'ready for contributions' or help wanted.
Thank you for your guidance.

@Sboonny
Copy link
Member

Sboonny commented Oct 3, 2023

I don't like the markdown files having styles affected by bootstrap, I think it's best for the long run to delete the classes from these twelve files, this will fix the border as well
image


my least favorite approach is to add more properties in these selectors, it should solve the issue

https://github.com/freeCodeCamp/freeCodeCamp/blob/3d2746cdcfd546f2a3a0724729adf91bec140857/client/src/components/layouts/global.css#L501-L510C2


last option is to delete this selector .table-striped>tbody>tr:nth-of-type(odd) in bootstrap.min.css

@naomi-lgbt
Copy link
Member

I'm fine with deleting the bootstrap classes, but then we should implement our own. The striped table is a nice look and I'd like to preserve it.

@gikf gikf added the scope: UI Threads for addressing UX changes and improvements to user interface label Oct 4, 2023
@Sboonny
Copy link
Member

Sboonny commented Oct 4, 2023

if the classNames are deleted, adding the styles is a simple, it will be adding selector and property, I am okay with that.


If you would like to fix this issue, please make sure you read our guidelines for contributing, we prioritize contributors following the instructions in our guides. Join us in our chat room or the forum if you need help contributing, our prolific contributors will guide you through this.

@Sboonny Sboonny added help wanted Open for all. You do not need permission to work on these. and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Oct 4, 2023
@lasjorg
Copy link
Contributor

lasjorg commented Oct 4, 2023

Do we make all tables have a striped style by default or create a new class for it?

@Sboonny
Copy link
Member

Sboonny commented Oct 4, 2023

All tables in challenge instructions.

Until we have tailwind, or something a like in the code base, I prefer the fewer cases of unique styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: UI Threads for addressing UX changes and improvements to user interface type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
6 participants