Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the confetti logic to the related redux-saga #51908

Closed
ahmaxed opened this issue Oct 11, 2023 · 6 comments · Fixed by #51938
Closed

Move the confetti logic to the related redux-saga #51908

ahmaxed opened this issue Oct 11, 2023 · 6 comments · Fixed by #51938
Labels
hacktoberfest help wanted Open for all. You do not need permission to work on these. type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have

Comments

@ahmaxed
Copy link
Member

ahmaxed commented Oct 11, 2023 •
edited

Is your feature request related to a problem? Please describe.

The following steps will improve the functionality and maintainability of the confetti feature:

  1. The confetti logic should be moved to the related redux-saga (execute-challenge-saga).
  2. The confetti should pop at the end of each block completion instead of certification projects.

Self-note: When Growthbook is fully incorporated with redux, put the confetti behind an AB test to measure its effect on user progress.
@ahmaxed ahmaxed added type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have help wanted Open for all. You do not need permission to work on these. hacktoberfest labels Oct 11, 2023
@ahmaxed
Copy link
Member Author

ahmaxed commented Oct 11, 2023

a2937, in case you are still interested.

@a2937
Copy link
Member

a2937 commented Oct 11, 2023

Thank you. I'll happily take on this issue.

@07tAnYa
Copy link

07tAnYa commented Oct 12, 2023

kindly assign this to me , I can work on this

@ahmaxed
Copy link
Member Author

ahmaxed commented Oct 12, 2023

No assignment is necessary as described in our contribution guidelines. The first comprehensive PR will be considered for review.

@Yash-Ambekar
Copy link
Contributor

@ahmaxed Can you please elaborate more on the issue?

@Riya267 Riya267 mentioned this issue Oct 12, 2023
Merged
4 tasks
@airwakz
Copy link

airwakz commented Oct 13, 2023

Assign this issue to me i will work on this asap

@airwakz airwakz mentioned this issue Oct 13, 2023
Closed
4 tasks
@a2937 a2937 mentioned this issue Oct 13, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest help wanted Open for all. You do not need permission to work on these. type: feature request Threads classified to be feature requests. Implementation to be considered as a nice to have
Projects
None yet
Milestone
No milestone
5 participants
@ahmaxed @a2937 @Yash-Ambekar @airwakz @07tAnYa