Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment Issue: Button in Email Sign-up Section #52131

Closed
JeevaRamanathan opened this issue Oct 27, 2023 · 9 comments · Fixed by #52132
Closed

Alignment Issue: Button in Email Sign-up Section #52131

JeevaRamanathan opened this issue Oct 27, 2023 · 9 comments · Fixed by #52132
Labels
scope: UI Threads for addressing UX changes and improvements to user interface status: PR in works Work in Progress (WIP) Issues. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@JeevaRamanathan
Copy link
Contributor

JeevaRamanathan commented Oct 27, 2023

Describe the Issue

In the email signup page the button appears to be misaligned resulting in an unbalanced layout.
es

Affected Page

https://www.freecodecamp.org/email-sign-up/

Steps to Reproduce

  1. Sign in as a new user on https://www.freecodecamp.org ( If you have accepted the Privacy Terms ).
  2. Upon successful sign-in, you will be redirected to the email signup screen.
  3. Scroll down until you reach the email subscription section.
  4. Observe that the button is misaligned.

Expected behavior

The button should be aligned properly within its container.
image

Screenshots

No response

System

  • Device: [Laptop]
  • Browser: [Edge, Chrome]

Additional context

I would like to work on this

@JeevaRamanathan JeevaRamanathan added status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. labels Oct 27, 2023
@JeevaRamanathan JeevaRamanathan changed the title Button Alignment in Email Sign-up Alignment Issue: Button in Email Sign-up Section Oct 27, 2023
@huyenltnguyen huyenltnguyen added status: PR in works Work in Progress (WIP) Issues. scope: UI Threads for addressing UX changes and improvements to user interface and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Oct 27, 2023
@huyenltnguyen
Copy link
Member

@ahmaxed This is unfortunately a regression caused by the Col migration 😞 I tried reverting the Col component replacement and got the correct alignment again.

The problem here is the Bootstrap version has float: left set while ours doesn't, so the fix should be adding this property in, but this would impact /learn and we will need to have yet another round of QA.

I'm leaning toward updating the component, but I also understand that it's not a good use of time to do another QA round for just an alignment issue, so I would like to get your recommendation here. Maybe we could go with a stopgap solution (adding a CSS rule to email-sign-up) and create an issue to track the cleanup?

References:

@Sujal942
Copy link

Hey @JeevaRamanathan i want to work in this issue.

@lucifer100201
Copy link

Hey @JeevaRamanathan I want to work in this issue and also fix the issue of button styling which is not aligned.

@huyenltnguyen
Copy link
Member

@Anshika-121
Copy link

Hello Sir @JeevaRamanathan I would like to work with you and solve the error.

@huyenltnguyen huyenltnguyen added status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. and removed status: PR in works Work in Progress (WIP) Issues. labels Oct 31, 2023
@ShreyasLakhani
Copy link

@JeevaRamanathan
https://github.com/freeCodeCamp/freeCodeCamp/assets/105536945/a01a68ac-a8fe-4888-85c5-18843b38002c

In the email signup page, after click on sing up it will automatic sign in without asking mail and redirect to /learn page.

image
this result not show.

any Idea? anyone.

@AbhinavSingh111
Copy link

AbhinavSingh111 commented Nov 1, 2023

HI , I have a working solution , please assign it to me.
I would like to work in this.

@huyenltnguyen
Copy link
Member

huyenltnguyen commented Nov 1, 2023

I'm limiting conversation in this issue thread to only moderators and staff members due to off-topic comments.

@JeevaRamanathan I'll follow up with you over your PR once the approach is finalized. And thank you for your patience!

@freeCodeCamp freeCodeCamp locked as off-topic and limited conversation to collaborators Nov 1, 2023
@ahmaxed
Copy link
Member

ahmaxed commented Nov 1, 2023

@huyenltnguyen, yes. We should add some CSS for this page for now and address and improve the col component or the grid system all together post migration.

@huyenltnguyen huyenltnguyen added status: PR in works Work in Progress (WIP) Issues. and removed status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. labels Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: UI Threads for addressing UX changes and improvements to user interface status: PR in works Work in Progress (WIP) Issues. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants