Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui]: upper jaw inline code string spacing #52498

Open
ShaunSHamilton opened this issue Dec 6, 2023 · 3 comments · May be fixed by #54556
Open

[ui]: upper jaw inline code string spacing #52498

ShaunSHamilton opened this issue Dec 6, 2023 · 3 comments · May be fixed by #54556
Labels
help wanted Open for all. You do not need permission to work on these. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@ShaunSHamilton
Copy link
Member

ShaunSHamilton commented Dec 6, 2023

The following Markdown:

Create a variable called `card_translation` and assign it a translation table to replace all `-` and ` ` characters with an empty string.

Renders as:

image

There is no space between the ` ` and the proceeding word characters.

There appears to be one in the HTML. So, I assume this is a CSS issue:
image

@ShaunSHamilton ShaunSHamilton added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. scope: UI Threads for addressing UX changes and improvements to user interface platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Dec 6, 2023
@huyenltnguyen
Copy link
Member

huyenltnguyen commented Dec 6, 2023

I think this has something to do with how markdown is converted to HTML. The text is wrapped within double quotes, but the empty space is not, which gives us an empty <code>.

@raisedadead
Copy link
Member

@ShaunSHamilton is this still the case and a confirmed bug? If yes, please consider moving it from triage and tagging help wanted as needed.

@ShaunSHamilton
Copy link
Member Author

This is still a confirmed bug:
https://www.freecodecamp.org/learn/scientific-computing-with-python/learn-how-to-work-with-numbers-and-strings-by-implementing-the-luhn-algorithm/step-3


An issue with the help wanted Open for all. You do not need permission to work on these. label is open for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.

To Fix:

  • Adjust CSS for the editor-upper-jaw or similar to ensure spacing between codeblocks and non-codeblocks.

If you would like to contribute, and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/

If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum

@ShaunSHamilton ShaunSHamilton added help wanted Open for all. You do not need permission to work on these. and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Feb 24, 2024
@suyeon-cha suyeon-cha linked a pull request Apr 28, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
3 participants