New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript Algorithms and DataStructures (beta): console tab is always closed by default #52802
Comments
I also faced the same issue, so I would like to work on this. |
I personally would support this change. There is an issue regarding syntax error being hidden as the console is closed by default (#52749), so having the console open by default would help address that. I think the expected behavior could be:
A small note here is that, if we decide to implement this change, the code changes should include sufficient tests to lock in the behavior. I'll wait for others to chime in before opening this up for contribution. |
I see two PRs here:
To close this issue, I suggest we just go with 1. The second will require more discussion about priority. @scissorsneedfoodtoo Do you have an opinion about defaulting the console to be open for the new JS stuff? |
Thanks for the mention, @ShaunSHamilton. A contributor who reviewed very early versions of the project-based JS curriculum suggested that we keep the console open by default for all the new JS projects, and I agree. Many include steps that involve logging things to the console, and learners can any syntax errors more easily. Like you mentioned, this can be handled with at least two PRs. The first can keep the console open by default for the JS curriculum, and the second can deal with storing learner preferences for the console state to local storage. I do like the behavior suggested by @huyenltnguyen, too, though it will require more discussion. |
Rather than defaulting to the console being open, which is not something we can do on mobile, I think the instructions should be updated to explicitly mention how to check the console. |
Describe the Issue
If the student opened console tab while doing some challenge step
then, after submitting correct solution for the step, and being redirected to next challenge step,
they will end up with the console tab being closed.
Such flow may be considered not the best user experience, especially for users, who would prefer to have the console tab always opened while working with JavaScript code.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8
Steps to Reproduce
pauseButton.addEventListener("click", pauseSong);
Submit and go to next challenge
button.Expected behavior
I see two possible options for the expected behaviour:
To make console be opened always by default
My personal opinion is that it would be more comfortable for working with JS, rather than have console closed by default. This is subjective though. It may be not the best experience for those who would prefer to use console only from time to time while going through lessons.
As an example of such experience, the old JS course or React lesson from Front End Development libraries course may be used.
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/
https://www.freecodecamp.org/learn/front-end-development-libraries/#react
To make console be opened or closed based on the console state from previous challenge
If I would have the console opened while doing this step https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-basic-string-and-array-methods-by-building-a-music-player/step-35,
after completing challenge and going for next one (https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-basic-string-and-array-methods-by-building-a-music-player/step-36),
console should be also opened.
Screenshots
No response
System
Additional context
No response
The text was updated successfully, but these errors were encountered: