Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect instructions in Step 16 of 'Learn Introductory JavaScript by Building a Pyramid Generator' #54451

Closed
jaytalbot opened this issue Apr 20, 2024 · 2 comments · Fixed by #54456
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: PR in works Work in Progress (WIP) Issues. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@jaytalbot
Copy link

Describe the Issue

The instructions are to add the (second) string: "Quincy," [with the comma]. However, you're then advised that the string should be "Quincy" without the comma.

You have to remove the comma to pass.

Affected Page

https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-introductory-javascript-by-building-a-pyramid-generator/step-16

Your code


let character = 'Hello';
let count = 8;
let rows = ["Naomi", "Quincy,", "CamperChan"];

Expected behavior

The code should have passed when the instructions were followed.

Screenshots

Screenshot 2024-04-20 153358 freeCodeCamp step 16

System

  • Device: Laptop
  • OS: Windows 11
  • Browser: Microsoft Edge
  • Version: 123.0.2420.97

Additional context

No response

@jaytalbot jaytalbot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. labels Apr 20, 2024
@jdwilkin4
Copy link
Contributor

jdwilkin4 commented Apr 20, 2024

The comma needs to be moved outside the backticks.

I'll go ahead and open this up for first timers only since it is a small change

@jdwilkin4 jdwilkin4 added first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. new javascript course These are for issues dealing with the new JS curriculum and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels Apr 20, 2024
@jdwilkin4
Copy link
Contributor

jdwilkin4 commented Apr 20, 2024

Note to contributors

This has been opened for contribution. The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors.

If you would like to contribute and have not read the contributors docs, please do so here: https://contribute.freecodecamp.org/#/

If you have any issues with contributing, be sure to join us on the contributors channel, or on the contributors sub-forum

Files that need to be changed

https://github.com/freeCodeCamp/freeCodeCamp/blob/main/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-introductory-javascript-by-building-a-pyramid-generator/660f039ff313dbb696b007ca.md

updated description

Change your `rows` declaration to be an array with the strings `"Naomi"`, `"Quincy"`, and `"CamperChan"`. The order of values in an array is important, so follow that order. Remember that strings are case-sensitive.

Happy coding

@jdwilkin4 jdwilkin4 added status: PR in works Work in Progress (WIP) Issues. and removed first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. labels Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: PR in works Work in Progress (WIP) Issues. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
2 participants