Replace hidden-xs
class with an isMobile
check
#54791
Labels
platform: learn
UI side of the client application that needs familiarity with React, Gatsby etc.
scope: UI
Threads for addressing UX changes and improvements to user interface
status: PR in works
Work in Progress (WIP) Issues.
Description
We are using the
hidden-xs
class to conditionally hide some text on mobile screens:freeCodeCamp/client/src/templates/Challenges/components/completion-modal.tsx
Lines 204 to 206 in 3f92fc6
This class comes from Bootstrap, which is something we are going to remove (#52030). So instead of using the class, we can use an
isMobile
check, like this (which is also a little more consistent with how we've handled this kind of conditional rendering):freeCodeCamp/client/src/templates/Challenges/classic/show.tsx
Lines 228 to 230 in 3f92fc6
Requirements
Update the
completion-modal
file to replace thehidden-xs
class with anisMobile
check.Notes
I noticed that we are using multiple methods for mobile device detection, so I think the check should be standardized, and there should be a shared util for this check. But I'm leaving this out of the scope of this issue, and will create a separate issue for it.
The text was updated successfully, but these errors were encountered: