Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the button-group class #54964

Closed
huyenltnguyen opened this issue May 24, 2024 · 1 comment · Fixed by #54966
Closed

Remove the button-group class #54964

huyenltnguyen opened this issue May 24, 2024 · 1 comment · Fixed by #54966
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface

Comments

@huyenltnguyen
Copy link
Member

Description

The button-group class is used in tool-panel.tsx:

className={`tool-panel-group button-group ${

The class doesn't have any effect because there isn't any .btn in tool-panel.tsx:

.button-group .btn:not(:last-child) {
margin-bottom: 10px;
}

That means it's safe to remove the class now.

Changes needed

  • Remove the .button-group .btn:not(:last-child) selector from global.css
  • Remove the button-group class from tool-panel.tsx
@huyenltnguyen huyenltnguyen added help wanted Open for all. You do not need permission to work on these. scope: UI Threads for addressing UX changes and improvements to user interface platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. labels May 24, 2024
@huyenltnguyen
Copy link
Member Author

This issue is open for contribution.

Please make sure you read our guidelines for contributing as well as our expectations from a pull request, we prioritize contributors following the instructions in our guides. Join us in our chat room or our forum if you need help contributing; our moderators will guide you through this.

Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first.

Happy contributing.

@ilenia-magoni ilenia-magoni removed the help wanted Open for all. You do not need permission to work on these. label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: UI Threads for addressing UX changes and improvements to user interface
Projects
None yet
2 participants