Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Twitchtv JSON API: Codepen example appears broken #7044

Closed
hey-its-iota opened this issue Feb 15, 2016 · 5 comments
Closed

Use the Twitchtv JSON API: Codepen example appears broken #7044

hey-its-iota opened this issue Feb 15, 2016 · 5 comments

Comments

@hey-its-iota
Copy link

http://codepen.io/FreeCodeCamp/full/adBpOw

The Codepen example linked to in the challenge appears broken. It is not showing any information other than the "Twitch Streamers" bar at the top.

Inspecting with Chrome, the page is encountering 16 errors on loading all similar to the following:

GET https://api.twitch.tv/kraken/streams/ESL_SC2?callback=jQuery21307896199643146247_1455574213075&_=1455574213076 net::ERR_INSECURE_RESPONSE
@ltegman
Copy link
Member

ltegman commented Feb 15, 2016

This is what certain browsers do when you try to access an HTTPS resource from an HTTP page. This link simply needs to be switched to https to prevent this from happening.

@ltegman ltegman added confirmed first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. labels Feb 15, 2016
@raisedadead
Copy link
Member

@ltegman I guess we can update all the codepen.io example links to HTTPS.
Better fix everywhere than just this challenge.

I'll put a PR if you agree.

@ltegman
Copy link
Member

ltegman commented Feb 16, 2016

@raisedadead Unfortunately you can also end up with a problem if the pen uses http resources and you link to the https version, so I'd just change this one unless you want to audit them all for what kind of resources they use.

@raisedadead
Copy link
Member

@ltegman yup you are right, I tested changing this challenge with HTTPS, and its already throwing warnings

Mixed Content: The page at 'https://s.codepen.io/FreeCodeCamp/fullpage/adBpOw?' was loaded over HTTPS, but requested an insecure image 'http://dummyimage.com/50x50/ecf0e7/5c5457.jpg&text=0x3F'. This content should also be served over HTTPS.

@raisedadead
Copy link
Member

Closing in favor of #7700

@ghost ghost removed the first timers only Open for anyone doing contributions for first time. You do not need permission to work on these. label May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants