Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated Italicize method #7512

Closed
trashtalka3000 opened this issue Mar 12, 2016 · 3 comments
Closed

Outdated Italicize method #7512

trashtalka3000 opened this issue Mar 12, 2016 · 3 comments
Assignees
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.

Comments

@trashtalka3000
Copy link

trashtalka3000 commented Mar 12, 2016

Challenge Change Text Inside an Element Using jQuery has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.2; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.111 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
In the descriptionof the challenge, it uses <i> to replace the italicized text with jquery instead of the <em> tag. In a previous challenge it mentions how <i>is outdated and usually used for icons in bootstrap now

ie.
$("h3").html("<i>jQuery Playground</i>");
should be:
$("h3").html("<em>jQuery Playground</em>");

My code:

<script>
  $(document).ready(function() {
    $("#target1").css("color", "red");

  });
</script>

<!-- Only change code above this line. -->

<div class="container-fluid">
  <h3 class="text-primary text-center">jQuery Playground</h3>
  <div class="row">
    <div class="col-xs-6">
      <h4>#left-well</h4>
      <div class="well" id="left-well">
        <button class="btn btn-default target" id="target1">#target1</button>
        <button class="btn btn-default target" id="target2">#target2</button>
        <button class="btn btn-default target" id="target3">#target3</button>
      </div>
    </div>
    <div class="col-xs-6">
      <h4>#right-well</h4>
      <div class="well" id="right-well">
        <button class="btn btn-default target" id="target4">#target4</button>
        <button class="btn btn-default target" id="target5">#target5</button>
        <button class="btn btn-default target" id="target6">#target6</button>
      </div>
    </div>
  </div>
</div>
@erictleung erictleung added the status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. label Mar 30, 2016
@erictleung
Copy link
Member

erictleung commented Mar 30, 2016

The earlier challenge you cited does say the i tags is used for icons now.

The i element was originally used to make other elements italic, but is now commonly used for icons. You add the Font Awesome classes to the i element to turn it into an icon, for example: ...

The W3C recommendationsays the i tags is:

The i element represents a span of text in an alternate voice or mood, or otherwise offset from the normal prose in a manner indicating a different quality of text, such as a taxonomic designation, a technical term, an idiomatic phrase from another language, transliteration, a thought, or a ship name in Western texts.

I would either make it clear which tag to use or accept both tags. @FreeCodeCamp/issue-moderators thoughts?

@SaintPeter
Copy link
Member

SaintPeter commented Mar 30, 2016

We might as well change it to <em> just so we'll stop getting these dang issues.

@raisedadead
Copy link
Member

raisedadead commented Mar 31, 2016

👍 for changing to <em>

@BerkeleyTrue BerkeleyTrue added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 31, 2016
@caravinci caravinci removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.
Projects
None yet
Development

No branches or pull requests

6 participants