Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS error on Codepen for challenge [show-relationships-with-a-force-directed-graph] #7617

Closed
kschoos opened this issue Mar 18, 2016 · 10 comments

Comments

@kschoos
Copy link

kschoos commented Mar 18, 2016

Challenge Show Relationships with a Force Directed Graph has an issue.
User Agent is: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:41.0) Gecko/20100101 Firefox/41.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.

Just opened the pen and it spits out a CORS error.

@ltegman
Copy link
Member

ltegman commented Mar 18, 2016

I can confirm this. I assume it's due to the example using http instead of https.

@kalunlee136
Copy link
Contributor

@Itergman Yeah, I tried changing the API request to https and it works fine.

@raisedadead
Copy link
Member

@kalunlee136 It would be awesome if you could send in a PR!

@raisedadead raisedadead added the help wanted Open for all. You do not need permission to work on these. label Mar 21, 2016
@kalunlee136
Copy link
Contributor

@raisedadead i don't think i can fix the codepen problem, because the issue is that the example API request inside the pen uses HTTP (that's why if you open the pen the graph doesn't show up). I think we would need the owner of the pen to change it.

Though I can work on changing the Hint URL from the FCC challenge so people don't copy and paste the wrong URL.

@raisedadead
Copy link
Member

@kalunlee136 The original Pen is by Free Code Camp (account under control of @QuincyLarson) so if you can create a Pen that has https within its code, then we could either clone it under the Free Code Camp account or use your pen.

Next thing though still would be to update the example links protocol to https in the challenge story as well!

@kalunlee136
Copy link
Contributor

@raisedadead ok, sounds good. I'll work on this.

@raisedadead
Copy link
Member

Refer #7700 for similar issues.

@mutantspore
Copy link

Yes, as the original author of
this D3 exercise, I have changed my original to https:// and can confirm that it works fine. I can't alter the official FCC version though. @QuincyLarson will have to do that.

Unfortunately with the phasing out of FCC News this is a dooooomed project anyway. :(

@raisedadead
Copy link
Member

@mutantspore Thanks for fixing the original pen.
Yup we are trying to look for a alternate data set!
Refer #7082

@raisedadead
Copy link
Member

Closing as resolved.

@raisedadead raisedadead changed the title CORS error on Codepen for challenge [show-relationships-with-a-force-directed-graph] CORS error on Codepen for challenge [show-relationships-with-a-force-directed-graph] Apr 15, 2016
@ghost ghost removed the help wanted Open for all. You do not need permission to work on these. label May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants