Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

personality #812

Closed
desult opened this issue Jun 3, 2015 · 8 comments
Closed

personality #812

desult opened this issue Jun 3, 2015 · 8 comments

Comments

@desult
Copy link

desult commented Jun 3, 2015

Challenge http://www.freecodecamp.com/challenges/waypoint-create-a-set-of-checkboxes has an issue. Please describe how to reproduce it, and include links to screen shots if possible.

Give your radio buttons the name attribute of "personality".

Cannot satisfy this request. This waypoint is on checkboxes and it is asking for me to edit the radio button. I've changed the checkboxes and the radio buttons to have name="personality" nothing works.

@desult
Copy link
Author

desult commented Jun 3, 2015

@treece
Copy link
Contributor

treece commented Jun 3, 2015

I was just about to report this because someone was having this issue in slacks help channel :) The problem seems to be in the test: "assert($('input[type=\"checkbox\"]:nth-child(1)').attr('name') === 'trait', 'Give your radio buttons the <code>name</code> attribute of \"personality\".')"

If you add the name trait to a checkbox then the challenge will pass.

This should fix the issue if you stick to the same instructions: "assert($('input[type=\"radio\"]:nth-child(1)').attr('name') === 'personality', 'Give your radio buttons the <code>name</code> attribute of \"personality\".')"

Hope this helps!

I think I might start contributing to fix these as they come up :-)

@desult
Copy link
Author

desult commented Jun 3, 2015

Thanks

@BerkeleyTrue
Copy link
Contributor

@desult Does @treece comment fix your issue?

@desult
Copy link
Author

desult commented Jun 3, 2015

@BerkeleyTrue The issue still exists. I've at least been able to get past that waypoint and move on.

The waypoint should be asking for name="trait" for the checkbox. not name="personality" for radio button.

@treece
Copy link
Contributor

treece commented Jun 3, 2015

@desult Yea, my commit hasn't been merged yet :-) but what I think @BerkeleyTrue is asking is if my comment and not commit allows the challenge to pass for you. The comment about adding the name trait to a checkbox passes the challenge for you? By your comment, it seems like that's a yes? correct?

If you add the name trait to a checkbox then the challenge will pass.

@QuincyLarson
Copy link
Contributor

Thank you for noticing this! I'm pushing a fix for this momentarily.

@desult
Copy link
Author

desult commented Jun 3, 2015

@treece Yes, I was able to pass the challenge by adding "trait" to name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants