Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random - Qoute-Machine code in codepen #9637

Closed
vaibsharma opened this issue Jul 9, 2016 · 3 comments
Closed

Random - Qoute-Machine code in codepen #9637

vaibsharma opened this issue Jul 9, 2016 · 3 comments
Labels
other: bike shedding Discussions that are not fruitful or concrete enough for actionable work. Should be closed.

Comments

@vaibsharma
Copy link

vaibsharma commented Jul 9, 2016

Challenge Build a Random Quote Machine has an issue.
User Agent is: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
Hi
I am Vaibhav Sharma . Recently while doing Random Quote Machine API based project , in the reference code of the project (which I opened just for the reference)I found the qoutes are missing the right qoute icon.
You can see them in the attached file.
screenshot from 2016-07-09 17 39 05.
I want you to review this bug ( Once you get free) .
Thank you

@abhisekp
Copy link
Member

abhisekp commented Jul 9, 2016

I would say, it's an unique design to present the quote 😏

Just a UI design decision to think out of the box.

@ImSerenityADev
Copy link

ImSerenityADev commented Jul 9, 2016

Visually, it creates a nice effect. It's also true people naturally look for closing quotes as it's sort of basic grammar thing.

@raisedadead raisedadead added the other: bike shedding Discussions that are not fruitful or concrete enough for actionable work. Should be closed. label Jul 11, 2016
@raisedadead
Copy link
Member

raisedadead commented Jul 11, 2016

It's just a visual style. Lot of quote sites use them and lots do not
For instance:

image

Closing as bikeshedding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other: bike shedding Discussions that are not fruitful or concrete enough for actionable work. Should be closed.
Projects
None yet
Development

No branches or pull requests

4 participants