This repository has been archived by the owner on Oct 16, 2019. It is now read-only.
Fix for ctrl key having no impact on submit process #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bouncey
suggested changes
Jun 18, 2018
| @@ -35,18 +35,46 @@ const options = { | |||
| required: ['solution', 'githubLink'] | |||
| }; | |||
|
|
|||
| var keysDown = { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -35,18 +35,46 @@ const options = { | |||
| required: ['solution', 'githubLink'] | |||
| }; | |||
|
|
|||
| var keysDown = { | |||
| Control: 0, | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
| handleKeyDown(e) { | ||
| if (e.key === 'Control') { | ||
| keysDown.Control = 1; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -58,7 +86,7 @@ export class ProjectForm extends PureComponent { | |||
| formFields={isFrontEnd ? frontEndFields : backEndFields} | |||
| id={isFrontEnd ? 'front-end-form' : 'back-end-form'} | |||
| options={options} | |||
| submit={this.handleSubmit} | |||
| submit={this.handleSubmit.bind(this)} | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
| handleKeyDown(e) { | ||
| if (e.key === 'Control') { | ||
| keysDown.Control = 1; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
joops75
force-pushed
the
fix/ctrl-enter-submit
branch
from
e03174f
to
ee3ec38
Compare
|
I've amended my commit as per requests. |
Bouncey
suggested changes
Jun 19, 2018
| } | ||
| handleKeyDown(e) { | ||
| if (e.key === 'Control') { | ||
| this.setState({ keysDown: { ...this.state.keysDown, Control: true } }); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
| handleSubmit(values) { | ||
| if ( | ||
| this.state.keysDown.Control && this.state.keysDown.Enter || |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
joops75
force-pushed
the
fix/ctrl-enter-submit
branch
from
ee3ec38
to
5f36ac5
Compare
joops75
force-pushed
the
fix/ctrl-enter-submit
branch
from
5f36ac5
to
3623af3
Compare
|
@Bouncey Re-amended commit. Hopefully this sorts it! |
|
No problem @Bouncey . Thanks for all the feedback! |
Bouncey
pushed a commit
to Bouncey/learn
that referenced
this pull request
Jul 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for issue 67. Keydown and keyup event listeners added to determine when enter and ctrl are pressed down. 'If' statement added to the handleSubmit function to check these two keys are pressed before submitting. This statement also covers the case that enter is not pressed and so the mouse must have been clicked to submit the form.
Additionally, the handleSubmit function was changed from an arrow function to match the formatting of the other functions.
Tested on my machine (Windows 7, Firefox Quantum 64-bit).