This repository has been archived by the owner on Oct 16, 2019. It is now read-only.
fix: increase spacing in challenge list #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes @nikrb! Finally I get to merge one of your PR's! I felt bad having to shelve News after you started to show a keen interest. Thank you for your perseverance and for your contribution! 👍 |
Bouncey
approved these changes
May 25, 2018
|
Nice work @nikrb |
nikrb
added a commit
to nikrb/learn
that referenced
this pull request
Jun 22, 2018
nikrb
added a commit
to nikrb/learn
that referenced
this pull request
Jul 3, 2018
Bouncey
added a commit
that referenced
this pull request
Jul 6, 2018
* fix: increase spacing in challenge list (#96) * enh: add button to download user solution on completion modal * fix: linting * review: remove dashedName grab from Show.js can generate dashedName in CompletionModal from challengeMeta * review: generate download file dashedName from challengeMeta.title * add className btn-primary-invert * review: shape files data we only want key indexhtml contents from files * review: remove class already defined in global.css * review: further changes only grab title from challenge meta change fiels prop-type to object remove duplicate class btn-primary-invert from CompletionModal.css generate download file name using util function dasherize * review: only show download button if there is something to download * fix: increase spacing in challenge list (#96)
Bouncey
added a commit
to Bouncey/learn
that referenced
this pull request
Jul 27, 2018
* fix: increase spacing in challenge list (freeCodeCamp#96) * enh: add button to download user solution on completion modal * fix: linting * review: remove dashedName grab from Show.js can generate dashedName in CompletionModal from challengeMeta * review: generate download file dashedName from challengeMeta.title * add className btn-primary-invert * review: shape files data we only want key indexhtml contents from files * review: remove class already defined in global.css * review: further changes only grab title from challenge meta change fiels prop-type to object remove duplicate class btn-primary-invert from CompletionModal.css generate download file name using util function dasherize * review: only show download button if there is something to download * fix: increase spacing in challenge list (freeCodeCamp#96)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase spacing between challenges in lists.
closes #91