Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: The Odin Project superblock #1168

Merged
merged 7 commits into from
Mar 21, 2024

Conversation

Nirajn2311
Copy link
Member

Checklist:

Closes #XXXXX

@Nirajn2311 Nirajn2311 marked this pull request as ready for review January 15, 2024 17:23
@Nirajn2311 Nirajn2311 requested a review from a team as a code owner January 15, 2024 17:23
@@ -226,7 +226,9 @@ class ChallengeViewModel extends BaseViewModel {

learnService.setLastVisitedChallenge(url, block);

if (challenge.challengeType == 11 || challenge.challengeType == 10) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use .contains() here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea that can be done. Will update in a future PR when adding a new cert

@Sembauke Sembauke merged commit f764a4a into freeCodeCamp:main Mar 21, 2024
3 of 6 checks passed
@Nirajn2311 Nirajn2311 deleted the feat/the-odin-project branch March 21, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants