Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: podcast episode preview content #1177

Merged

Conversation

Sanket6652
Copy link
Contributor

Checklist:

Removed HTML widget because of maxLines property did not work as expected if the content contains elements like line breaks or other block-level elements that can break the line. That's why I added the text widget, by parsing the body of the description used as textcontent in the widget. By using the text widget we can see max lines 3

Closes #1175

@Sanket6652 Sanket6652 requested a review from a team as a code owner January 19, 2024 08:57
@Sembauke
Copy link
Member

Links won't be clickable anymore, we should probably use the HTML widget, despite the text being longer than 3 lines.

@Sanket6652
Copy link
Contributor Author

Sanket6652 commented Jan 20, 2024

ok, the link is only clickable if it has 'href" tag only, some of the links are not in href tag.

@Nirajn2311
Copy link
Member

Links won't be clickable anymore, we should probably use the HTML widget, despite the text being longer than 3 lines.

I think that's fine as this is just a preview of the what the episode has to offer. The clickable links and more details can be seen in the respective episode view.

Copy link
Member

@Nirajn2311 Nirajn2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The analyzer has reported some errors in your code. You can view them by running flutter analyze. Also where are you making these changes from as they seem to be somehow bypassing the pre-commit check.

@Nirajn2311 Nirajn2311 changed the title fix: Podcast episode preview content is same for all episodes #1175 fix: podcast episode preview content Jan 20, 2024
@Nirajn2311 Nirajn2311 merged commit b6b4356 into freeCodeCamp:main Jan 23, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podcast episode preview content is same for all episodes
3 participants