Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci grant permission #1229

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: ci grant permission #1229

merged 1 commit into from
Apr 18, 2024

Conversation

Nirajn2311
Copy link
Member

@Nirajn2311 Nirajn2311 commented Apr 16, 2024

Checklist:

The CI test was failing for android devices because in PR #1225 I had bumped the android version to API 33(Android 13) to be in line with the target version present in the android config files. In Android 13, the notification permission dialog was introduced and since the tests were not updated to handle it, they were all waiting for a response thereby leading to the action to never end & overtime at 6 hrs.

Thanks to the folks who solved this bounty(FilledStacks/acceptpermission_bounty#1) I could get this to work locally. Now to test it in the CI 馃

@Nirajn2311 Nirajn2311 marked this pull request as ready for review April 16, 2024 19:43
@Nirajn2311 Nirajn2311 requested a review from a team as a code owner April 16, 2024 19:43
@Sembauke Sembauke merged commit d150935 into main Apr 18, 2024
4 of 5 checks passed
@Sembauke Sembauke deleted the fix/ci-grant-permission branch April 18, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants