Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Need to have a generalized donation receipt that can be customized with the organization's name, EIN, contact info, etc. #119

Open
jasonsreynolds opened this issue Jun 15, 2017 · 19 comments · Fixed by #245

Comments

@jasonsreynolds
Copy link

No description provided.

@jasonsreynolds jasonsreynolds created this issue from a note in Reactification (To Do) Jun 15, 2017
@jspaine
Copy link
Contributor

jspaine commented Jun 15, 2017

Can you give an list of exactly what fields might be needed, or how variable is this stuff likely to be? Maybe it should be possible to add arbitrary fields to the general settings section.

@jasonsreynolds jasonsreynolds changed the title Need to have a generalized donation receipt that can be customized with the organization's name, EIN, contract info, etc. Need to have a generalized donation receipt that can be customized with the organization's name, EIN, contact info, etc. Jul 5, 2017
@jspaine
Copy link
Contributor

jspaine commented Aug 22, 2017

I think to finish this there needs to be something like:

  • An EIN field in the general settings

  • A new placeholder for the receipt in common/placeholders. It should be required and added to the email during db seeding, like the password reset url placeholder. It should render a table with the donated items and values and total.

  • To make it look a bit more receipt like, there could be another table as part of the donation receipt with the organization details and EIN number from general settings.

  • Instead of having the EIN field hard coded there could be a settings section for extra receipt related fields, similar to the create donation items fields and household section on the customer application. So by default it would be one field, Name: EIN, Value: whatever, but you could rename it or add other fields appropriate for your country.

  • Bonus if an example table can be rendered inside the editor too

@ronaldblanco
Copy link
Contributor

Hello Jspaine
Hey I am back, and I saw someone it is working on the issue 171.
I will be working on this.
In the "An EIN field in the general settings" do you only need the field with that name??

Thanks.

@jspaine
Copy link
Contributor

jspaine commented Sep 20, 2017

Hey, welcome back!

Yeah just that field is fine.

@ronaldblanco
Copy link
Contributor

Hey I did a pull request for the "An EIN field in the general settings" problem, this time I did check the eslint (server an client) to avoid future problems.
I will be checking the placeholder need (2 point) and I will ask you if I need your help.

Thanks.

@ronaldblanco
Copy link
Contributor

Hey I need help;
I am trying to play as a donor (to test my changes) but before make anything I am unable to add my own donations (as a donor user); I get constantly error 401, unauthorized user on my console of the server.
Do I am missing something?? I had tried creating the user with the application and also writing directed to the database, but, same result all the time.
Thanks.

@davycheung
Copy link
Contributor

Hi, @ronaldblanco I think I found the issue, and added a pull request to fix it.

@ronaldblanco
Copy link
Contributor

Thanks @davycheung, I will be testing it.

@ronaldblanco
Copy link
Contributor

Hello everyone;

I am working on the second point of this issue but I am unable to make my tests; what do I need to get my local app sending email so I can test my changes??
I have enable the google authentication and map.
My donor account also have a real email on it.
What else do I need?

Thanks.

@jspaine
Copy link
Contributor

jspaine commented Sep 23, 2017

You need a sendgrid account, set up an api key and add it to server/config/env/secrets.js.

I'd just add a console.log to the sendEmail function in server/config/mailer.js though.

ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Sep 25, 2017
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Sep 25, 2017
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Sep 25, 2017
@ronaldblanco
Copy link
Contributor

Hello @jspaine and thanks for the advise.
Hey I did a pull request I just leave a couple of comments in the code to test the result in the case I have to still made some changes.
So let me know how you see this.

Thanks for your help.

ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Sep 25, 2017
@jspaine jspaine reopened this Sep 25, 2017
@ronaldblanco
Copy link
Contributor

Hey, can someone give me more detailed information about what is wanted in the 4 point?

Thanks.

@jspaine
Copy link
Contributor

jspaine commented Sep 26, 2017

Was thinking to make it look a bit more receipt like, there could be another table as part of the donation receipt with the organization details and EIN number from general settings.

Then, instead of having the EIN field hard coded there could be a settings section for extra receipt related fields, similar to the create donation items fields and household section on the customer application. So by default it would be one field, Name: EIN, Value: whatever, but you could rename it or add other fields appropriate for your country.

I'll split that part into those 2 steps if you want to just try one to start.

@ronaldblanco
Copy link
Contributor

OK @jspaine; let me know when the split is ready so I begin with the first step.
Thanks.

@jspaine
Copy link
Contributor

jspaine commented Sep 27, 2017

Just meant I'd update the comment at the top with the list of objectives, it's done now.

@ronaldblanco
Copy link
Contributor

I will be working on the 3 point.

ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Sep 27, 2017
@ronaldblanco
Copy link
Contributor

Hey @jspaine, check this pull request and tell me if that is the idea of the 3 point.

Thanks.

ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Sep 29, 2017
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Oct 2, 2017
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Oct 3, 2017
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Oct 4, 2017
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Oct 4, 2017
@ronaldblanco
Copy link
Contributor

Hey @jspaine, could you help me with more info about the 4 point here??
The idea I get it is to do the ein field not part of the model; but in that case where will you put it?? I think I am missing something here.

Thanks

@jspaine
Copy link
Contributor

jspaine commented Oct 4, 2017

Hey, no it'll still be part of the model. just in an array of receiptFields or something. So you'd define a receiptFieldsSchema like

{
  name: {
    type: String,
    required: true
  },
  value: {
    type: String,
    required: true
  }
}

then in the settings schema:

...
receiptFields: [receiptFieldsSchema]
...

ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Oct 5, 2017
…could be a settings section for extra receipt related fields, similar to the create donation items fields and household section on the customer application
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Oct 9, 2017
…could be a settings section for extra receipt related fields, similar to the create donation items fields and household section on the customer application
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Oct 9, 2017
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Nov 24, 2017
…could be a settings section for extra receipt related fields, similar to the create donation items fields and household section on the customer application
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Nov 24, 2017
…could be a settings section for extra receipt related fields, similar to the create donation items fields and household section on the customer application
ronaldblanco added a commit to ronaldblanco/pantry-for-good that referenced this issue Nov 27, 2017
…could be a settings section for extra receipt related fields, similar to the create donation items fields and household section on the customer application
jspaine pushed a commit that referenced this issue Nov 27, 2017
…ettings section for extra receipt related fields, similar to the create donation items fields and household section on the customer application (#261)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants