New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move scripts to root and use pnpm #200
Conversation
5467b6e
to
9bf6b9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single borken point I could find. Seems unrelated, but is still braking due to workspaces.
Which brings me to: Do we really want all of these unrelated scripts to be a part of a workspace?
To be honest, I just dislike the need to install 100s of unrelated root npm packages just because I wanted to run a single script with 2 root deps.
Agreed. I will update this in the morning. |
Given that it takes all of 3 seconds to install everything, I'd just go with workspaces. It seems simpler to me.
Even that shouldn't be a problem if pnpm/pnpm#6300 is fixed. Edit: I know this is bikeshedding territory, though, so please just do what seems reasonable. I don't want to block this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with this 👍
Merging because I want to add a few scripts I have lying around. |
This PR moves the script packages into the repo root and uses pnpm. In a later PR, we can consolidate some of these, like
chat
andchat-emails
and, of course, anything else that is broken.In theory, nothing should have because they were never interdependent.