Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to PHP 8, tighten/collect:^9 #21

Open
tacman opened this issue Dec 13, 2022 · 1 comment
Open

Bump to PHP 8, tighten/collect:^9 #21

tacman opened this issue Dec 13, 2022 · 1 comment

Comments

@tacman
Copy link

tacman commented Dec 13, 2022

Now that php 7.4 is officially EOL, what do you think of dropping support for the older versions?

That would allow for upgrading the library to return typehints, etc.

Or, at a minimum what do you think of requiring ^7.4|^8.0 in composer.json, and tighten/collect:^8.0|^9.0

I can make a PR if you're okay with that. My preference would be for PHP 8.0+, but maybe you'd want that to be a new release.

@tacman
Copy link
Author

tacman commented Jan 14, 2024

OK, now collect has been deprecated, it should be replaced with composer require illuminate/collections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant