Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drm_prime_handle_to_fd_ioctl: translate O_ flags for Linuxulator #35

Merged
merged 1 commit into from Nov 6, 2020

Conversation

valpackett
Copy link
Contributor

Fixes FreeBSDDesktop/kms-drm#248 (damn why do we still have two repositories >_<)

note: I first wanted to do this in linux_ioctl.c in the linuxulator itself, but there we get the ioctl data before copying it from userspace, so that would mean copyin-fix-copyout which is awful.

testing: /compat/linux/bin/strace /compat/linux/bin/glxgears without any dri3 disabling variables (might also need to rebuild and reload linsysfs with https://reviews.freebsd.org/D26836 applied especially on amdgpu) — should be rendering in hardware, DRM_IOCTL_PRIME_HANDLE_TO_FD should be present without errors in the syscall trace

@zeising
Copy link
Member

zeising commented Oct 18, 2020

Against which branches does this apply? master isn't used, it was only used to import sources from Linux iirc.

@zeising
Copy link
Member

zeising commented Oct 18, 2020

Against which branches does this apply? master isn't used, it was only used to import sources from Linux iirc.

Disregard the above, was looking at the wrong repo..
Does this apply to the FreeBSD 12.1 and 11.4 versions as well?

@valpackett
Copy link
Contributor Author

Yes, this should apply everywhere.

was looking at the wrong repo

haha this strikes again

damn why do we still have two repositories

@trasz
Copy link
Member

trasz commented Oct 29, 2020

Ping? Has this been committed? If no, what's required?

@evadot evadot merged commit fd879cb into freebsd:master Nov 6, 2020
@valpackett valpackett deleted the linuxulator-fix branch May 5, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux binaries, DRI3 and drm_prime_handle_to_fd_ioctl
4 participants