Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: 2023q1: drm-drivers: corrections, suggestions #146

Closed
wants to merge 1 commit into from

Conversation

grahamperrin
Copy link
Contributor

One correction to spelling, add a missing word, minor adjustments to grammar.

Whilst here: a handful of other suggestions.

One correction to spelling, add a missing word, minor adjustments to grammar.

Whilst here: a handful of other suggestions.
Copy link
Member

@lsalvadore lsalvadore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by the status team, once you have decided if mentioning 13.1 or not.

@grahamperrin
Copy link
Contributor Author

Thanks.

I have this now amongst local commits, I'll not push to freebsd main until after the 13.2-related doc slush ends.

% git -C /usr/doc log -n 2 --oneline 
d4f7257766 (HEAD -> main) Porter's Handbook: wildcard arch, arch-neutral
af41f05cfc status: 2023q1: drm-drivers: minor changes
% 

@lsalvadore
Copy link
Member

@grahamperrin: I am fine with you waiting to push this as long as it does not slow down the status reports publication. For now, as you know, we are still waiting some reports and working on some submissions, so there is no hurry.

However, please let me encourage you to play a bit with git, in particular with git branch, git cherry-pick and git reset. For example, in this case, you can push af41f05cfc without pushing d4f7257766 by doing the following:

  • create a duplicate of your main branch with git branch duplicate main (the duplicate branch will be named duplicate);
  • checkout your main branch with git checkout main (in case you have not already checked out it);
  • hard reset you main branch to the commit that preceds af41f05cfc with git reset --hard af41f05cfc;
  • cherry-pick the commit for this pull request with git cherry-pick af41f05cfc;
  • push the change with git push;
  • put back d4f7257766 in your main branch with git cherry-pick d4f7257766.

In general, I suggest you use a new branch for each change and use your main branch to track upstream only. Once a change is ready in some branch, then you cherry-pick it in your main branch and push. (For changes that need more commits in the same branch, you would need to play with git rebase and git merge, but I guess this is not needed much in doc.)

You should be safe experimenting with git as long as you ensure the two following conditions are always satisfied:

  • whenever you use git reset or some other command that drops commits you still have the same commits in another backup branch;
  • whenever you git push you check carefully what you are actually pushing.

grahamperrin added a commit to grahamperrin/freebsd-doc that referenced this pull request Apr 5, 2023
One correction to spelling, add a missing word, minor adjustments to
grammar, a handful of other minor changes.

Approved by:  dumbbell, status (salvadore)
Pull request: freebsd#146
@grahamperrin
Copy link
Contributor Author

… I'll not push to freebsd main until after the 13.2-related doc slush ends. …

Through trying to work with branches with git at the command line, I ended up with

  • two commits pushed too soon
  • the one commit that I did want pushed, not pushed.

For now, I prefer to not discuss command-line use.

@grahamperrin grahamperrin deleted the patch-5 branch April 5, 2023 05:21
@lsalvadore
Copy link
Member

Thanks @grahamperrin for the commit and if you ever want want or need to train your git skills feel free to ask me for help if you want. You might also want to consider creating a new git repository completely unrelated to FreeBSD and fully in your control to practice with extra safety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants