Status: 2023q3: Wifibox: corrections, changes #270
Conversation
Add the missing URL parts of the links lines. Americanisation of the heading, consistent with past status reports. Create subheadings for system requirements, and for features. Make more use of normal paragraphs, less use of bullet points. Reorder things, to add clarity. Conciseness and other suggested changes. Pull-request: freebsd#270 Closes: freebsd#270 Signed-off-by: Graham Perrin <grahamperrin@gmail.com>
grahamperrin
force-pushed
the
grahamperrin-wifibox
branch
from
2010a21
to
9a34cc2
Compare
|
@pgj for your consideration. Thank you. |
There was a problem hiding this comment.
I approve the Links part (once the typo is fixed).
The rest should be approved by the original author @pgj.
|
Thank you. I am not sure I understand why it was necessary to change the text structure beyond style, formatting, and grammar fixes. For example, the description says "less use of bullet points" while it replaces the original 6 bullet points with 8. Is there a very specific style that is expected for the entries? |
|
No @pgj, there is no very specific style expected beside what you can find at https://docs.freebsd.org/en/books/fdp-primer/writing-style/ and https://docs.freebsd.org/en/articles/freebsd-status-report-process/#_instructions_for_writers. @grahamperrin found the structure he proposed clearer and made a suggestion. You are free to reject it if you liked your original text more. |
|
Sorry, it was not evident for me that this is a suggestion. My original pull request was closed and then I was thanked here for my consideration -- but nothing else. If there is no other special consideration I should have complied, then yes, please keep my original structure of text. Do not get me wrong, I appreciate the effort but reading through the proposed version I was not convinced that it would offer the readers a better presentation on the topic. I thought that the changes were needed because how other reports look like. |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Lorenzo Salvadore <developer@lorenzosalvadore.it>
|
(A very interesting project, by the way!) |
With my previous commit, copy and paste resulted in loss of a line.
This comment was marked as resolved.
This comment was marked as resolved.
|
Sure, I am fine with changes in the grammar and changing the sentences themselves. (I am far from being a native English speaker with my Ugric linguistic heritage.) What I would prefer instead is that please do not change the order of the sentences and the composition (hence number) of the paragraphs. |
Approved by: pgj (report author) Pull Request: #270
|
Merged, thanks. |
|
Sorry, I made final suggestions with GitHub not showing me the closure. (It was a draft, intentionally.) If you're interested, 263c026 |
Approved by: pgj (report author) Pull Request: freebsd#270
Approved by: pgj (report author) Pull Request: freebsd#270
Add the missing URL parts of the links lines.
Americanisation of the heading, consistent with past status reports.
Create subheadings for system requirements, and for features.Make more use of normal paragraphs, less use of bullet points. Reorder things, to add clarity.Conciseness and other suggested changes/corrections.