Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small correction about architectures near the beginning of the page #281

Closed
wants to merge 2 commits into from

Conversation

duckyondiscord
Copy link

No description provided.

@bsdjhb
Copy link
Member

bsdjhb commented Oct 16, 2023

A good clarification, but I might reword it a bit further as:

The `amd64` indicates that the system in this example is running the port of FreeBSD to the 64-bit x86 architecture.

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that while ducky is a perfectly fine name, we don't accept contributions from emails that we can't actually email to, especially x@users.noreply.github.com

@duckyondiscord
Copy link
Author

duckyondiscord commented Oct 21, 2023

note that while ducky is a perfectly fine name, we don't accept contributions from emails that we can't actually email to, especially x@users.noreply.github.com

Alright well you can email me at duccywastaken@pm.me then, I should add it to my github profile.

@duckyondiscord
Copy link
Author

A good clarification, but I might reword it a bit further as:

The `amd64` indicates that the system in this example is running the port of FreeBSD to the 64-bit x86 architecture.

I personally think that's unnecessarily complicating it a little. You can make that change if you want but I think simpler's better in this case.

Co-authored-by: Graham Perrin <grahamperrin@gmail.com>
@grahamperrin
Copy link
Contributor

#281 (comment)

… the port of FreeBSD to …

+1

I get it, however …

… if I close my eyes, intentionally not reminding myself of what's already at page, I imagine https://www.freebsd.org/about/ being a good/better place for something along the lines of:

FreeBSD and much of the complementary software in its ports collection is ported to ….

(Clumsily worded, but you get the idea.)

If a newcomer dives straight into the 'FreeBSD Basics' chapter with no prior knowledge of FreeBSD, no prior knowledge of the concept of porting: the reader might look away to https://docs.freebsd.org/en/books/handbook/glossary/#_p or https://www.freebsd.org/ports/ for a meaning of the word port.

HTH, happy to discuss in Matrix or IRC (to not derail things here).

@duckyondiscord
Copy link
Author

Is there anything else I need to do here?

@bsdjhb
Copy link
Member

bsdjhb commented Nov 22, 2023

A good clarification, but I might reword it a bit further as:

The `amd64` indicates that the system in this example is running the port of FreeBSD to the 64-bit x86 architecture.

I personally think that's unnecessarily complicating it a little. You can make that change if you want but I think simpler's better in this case.

One thing to note is that we use "64-bit x86" in other places to refer to amd64 (e.g. https://www.freebsd.org/platforms/) so that phrase is more consistent with existing language than "x86 64-bit". The other thing is that "version" is somewhat ambiguous in this case as "version" in FreeBSD usually means the release version (e.g. 13.2 vs 14.0) rather than the platform (which is what "amd64" vs "i386" is about). That is a pre-existing bug though of course. :) If we want to avoid the term "port" then perhaps

The `amd64` indicates that FreeBSD is running on a 64-bit x86 system.

I think the second commit is probably a bit too short as the existing language aims to be a bit of a tutorial explaining what various words mean, so keeping it verbose to match the other sentences seems more consistent.

freebsd-git pushed a commit that referenced this pull request Dec 8, 2023
Other architectures can be 64-bit, too.

Co-authored-by:	ducky <duccywastaken@pm.me>
Pull Request:	#281
@bsdjhb
Copy link
Member

bsdjhb commented Dec 8, 2023

Merged in 45ee577. Thanks!

@bsdjhb bsdjhb closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants