Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in DNS #326

Closed
wants to merge 1 commit into from
Closed

Typo in DNS #326

wants to merge 1 commit into from

Conversation

ZePotente
Copy link
Contributor

understanded -> understood

@igalic
Copy link
Contributor

igalic commented Jan 11, 2024

@ZePotente could you please fix up your git commit email address to be something valid, and not a @users.noreply.github.com> address.

@igalic igalic mentioned this pull request Jan 11, 2024
@rilysh rilysh mentioned this pull request Jan 14, 2024
@ZePotente
Copy link
Contributor Author

Is the commit mail issue solved now or do I have to amend the commit?

@igalic
Copy link
Contributor

igalic commented Jan 14, 2024

an easy way to check is to append .patch up the pull request URLs:

https://github.com/freebsd/freebsd-doc/pull/326.patch

that should show you what will get committed.
and right now, the email address is showing @noreply

@dbaio
Copy link
Member

dbaio commented Jan 18, 2024

Thanks @igalic

@ZePotente Thanks for your contribution.

To properly register your contribution, we will need your e-mail and name. This is what we are receiving at this moment:

Eze Posada <45889786+ZePotente@users.noreply.github.com>

Alternatively, if you prefer not to share your email, that's perfectly fine. We can simply add a line like this in the commit message:

Submitted by:    your name or username

@ZePotente
Copy link
Contributor Author

I'm sorry for the inconvenience, I don't really understand where these things are done in the github web UI and I don't really want to make fixing typos more trouble than it's worth. I just saw a couple of typos and wanted them gone.
If you can or want to you can add the "Submitted by" line or any other method you see fit in order to just solve this.

@igalic
Copy link
Contributor

igalic commented Jan 18, 2024

these are not things that can be fixed in the UI, without much effort.

on the CLI you'd have to pull the branch down, edit the author, and push it back:

git clone --branch patch-1 git@github.com:ZePotente/freebsd-doc
cd freebsd-doc
git commit --amend --author="Your Name <your@email>"
git push --force origin patch-1

understanded -> understood
@dbaio dbaio added the ready label Feb 24, 2024
freebsd-git pushed a commit that referenced this pull request Feb 24, 2024
understanded -> understood

Reviewed by:	Pau Amma <pauamma@gundo.com>, dbaio
Pull Request:	#326
@dbaio dbaio added merged and removed ready labels Feb 24, 2024
@dbaio
Copy link
Member

dbaio commented Feb 24, 2024

Committed on ae59c39
Thanks

@dbaio dbaio closed this Feb 24, 2024
@dbaio dbaio self-assigned this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants