Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix path details for nullfs in thin jails #334

Closed
wants to merge 1 commit into from

Conversation

SebAlbert
Copy link
Contributor

@SebAlbert SebAlbert commented Jan 27, 2024

After following all the instructions about thin jails with nullfs, I found I needed to make these two changes in order for it to work properly. I think these are errors in the handbook.

@@ -625,7 +625,7 @@ thinjail {

# HOSTNAME/PATH
host.hostname = "${name}";
path = "/usr/local/jails/containers/${name}";
path = "/usr/local/jails/thinjail-nullfs-base";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another PR #302 fixing this.

@@ -578,7 +578,7 @@ The next step is to create the symlinks to the `skeleton` by executing the follo
# ln -s skeleton/etc etc
# ln -s skeleton/home home
# ln -s skeleton/root root
# ln -s skeleton/usr/local usr/local
# ln -s ../skeleton/usr/local usr/local
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for spotting this.

@dbaio
Copy link
Member

dbaio commented Feb 24, 2024

Note for a committer, I marking this as ready, but please, remove this part before committing:

 -  path = "/usr/local/jails/containers/${name}";
 +  path = "/usr/local/jails/thinjail-nullfs-base";

@dbaio dbaio added the ready label Feb 24, 2024
freebsd-git pushed a commit that referenced this pull request Feb 24, 2024
@dbaio dbaio added merged and removed ready labels Feb 24, 2024
@dbaio
Copy link
Member

dbaio commented Feb 24, 2024

Committed on 1d0c527
Thank you!

@dbaio dbaio closed this Feb 24, 2024
@dbaio dbaio self-assigned this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants