handbook/wine: add Mizuma's source code URL, and small typos #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rilysh
commented
Mar 25, 2024
rilysh
commented
- It's particularly interesting to know what games/apps are currently "supported" through Mizuma, so it's a good idea to link the source code URL (winetricks source code URL is also already mentioned.)
- Remove the word "some" from the synopsis. It's ambiguous to know the meaning of "some" here, whereas Wine is intended (and does support) a wide range of Windows applications out of the box.
- Use the word GitHub instead Github (ignorable).
- Also edit the Arch Wiki URL (it redirects to that new URL from the previous one) (forgot to mention in the commit).
1. It's particularly interesting to know what games/apps are currently "supported" through Mizuma, so it's a good idea to link the source code URL (winetricks source code URL is also already mentioned.) 2. Remove the word "some" from the synopsis. It's ambiguous to know the meaning of "some" here, whereas Wine is intended (and does support) a wide range of Windows applications out of the box. 3. Use the word GitHub instead Github (ignorable). Signed-off-by: rilysh <nightquick@proton.me>
|
Thanks for the changes. I'll make the commit this night. |
|
Friendly reminder, ping. |
concussious
approved these changes
Apr 27, 2024
kaduk
approved these changes
Jun 5, 2024
| @@ -52,7 +52,7 @@ endif::[] | |||
| == Synopsis | |||
|
|
|||
| https://www.winehq.org/[WINE], which stands for Wine Is Not an Emulator, is technically a software translation layer. | |||
| It enables to install and run some software written for Windows(R) on FreeBSD (and other) systems. | |||
| It enables to install and run software written for Windows(R) on FreeBSD (and other) systems. | |||
There was a problem hiding this comment.
I fixed this with a follow-up commit since it was a preexisting issue unaffected by your edit, but "enables" is a transitive verb that needs a direct object, like "it enable users to install and run software" ... but "users" is pretty vague in this context so I went with an alternative verb that is intransitive.
There was a problem hiding this comment.
Thanks for the update!
| @@ -556,7 +556,7 @@ image::winetricks-uninstall-3.png[] | |||
| [[homura]] | |||
| === Mizutamari | |||
|
|
|||
| Mizutamari is an application similar to `winetricks`, although it was inspired by the https://lutris.net/[Lutris] gaming system for Linux. | |||
| https://codeberg.org/Alexander88207/Mizutamari[Mizutamari] is an application similar to `winetricks`, although it was inspired by the https://lutris.net/[Lutris] gaming system for Linux. | |||
There was a problem hiding this comment.
It's also available in the ports collection as games/mizuma, but the link to its homepage seems more appropriate than the ports collection entry, for this purpose, so I left it alone.
freebsd-git
pushed a commit
that referenced
this pull request
Jun 5, 2024
1. It's particularly interesting to know what games/apps are currently "supported" through Mizuma, so it's a good idea to link the source code URL (winetricks source code URL is also already mentioned.) 2. Remove the word "some" from the synopsis. It's ambiguous to know the meaning of "some" here, whereas Wine is intended (and does support) a wide range of Windows applications out of the box. 3. Use the word GitHub instead Github (ignorable). Signed-off-by: rilysh <nightquick@proton.me> Pull Request: <#360
|
This is committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.