Fix glib-mkenums Unicode issues #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR: 226693
Many ports use Unicode characters in their sources, and when glib-mkenums is processing them with a 'C' locale, it fails with a UnicodeDecodeError.
|
Looks like this was silently included in the final diff freebsd/freebsd-ports@1f45d9e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a UTF-8 locale: https://gitlab.gnome.org/GNOME/glib/issues/1430 — I figured the best place is
gnome.mk— we have these inmeson.mkandgem.mkalready.This fixes some exp-run failures:
http://package22.nyi.freebsd.org/data/104amd64-default-PR229761/2018-07-19_19h24m12s/logs/errors/libgnome-2.32.1.loghmm that doesn't usegnomeor react toUSE_LOCALEhttp://package22.nyi.freebsd.org/data/104amd64-default-PR229761/2018-07-19_19h24m12s/logs/errors/mousetweaks-3.12.0_1.log
libgda5 actually had weird mixed encodings instead of UTF-8, I added patches I found in other distros for that. [Previously posted as bug 226693]
http://package23.nyi.freebsd.org/data/104i386-default-PR229761/2018-07-19_19h24m20s/logs/errors/libgda5-5.2.4_2.log