Skip to content
This repository has been archived by the owner on Mar 1, 2023. It is now read-only.

2022q1/Makefile: Add file #471

Merged
merged 3 commits into from Jun 9, 2022
Merged

2022q1/Makefile: Add file #471

merged 3 commits into from Jun 9, 2022

Conversation

lsalvadore
Copy link
Member

New tools are being developed to generate reports automatically. This commit creates a Makefile for the 2022q1 quarterly report, in the same style as in the past.

Please review if I inserted each report in the right category and if you agree with the order. Feel free to change whatever you believe should be changed.

New tools are being developed to generate reports automatically. This
commit creates a Makefile for the 2022q1 quarterly report, in the same
style as in the past.
# Objects that defy categorization
Miscellaneous= hellosystem.adoc pot.adoc

.include <../tools/Makefile>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That file doesn't exist. (Or doesn't exist yet, at least.)

But more importantly, all the documents are listed here, except intro.adoc, which may have been left out deliberately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing pauamma.

Indeed, tools/Makefile does not exist yet: I am still working on it. As we are already late for 2022q1 and I need revision for the reports sorting, I thought it might be a good idea to send this file in advance for review, while I am finishing the rest.

As you guessed, intro.adoc is special and will be treated differently: it does not belong to any category and is always the first file to be included, there is no need for a variable in this case. So its absence is intended.

@lsalvadore lsalvadore merged commit 0d09410 into freebsd:main Jun 9, 2022
Copy link
Contributor

@pauamma pauamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the filenames supposed to be in alphabetical order within a section?

@lsalvadore
Copy link
Member Author

No, they are supposed to be in the same order we want them in the final report. I suggest looking at what the order was in the last report and keep the same when possible. To make it easier, I have initialized the new 2022q2/Makefile with some reports already placed in the same order than last quarter (the reports have not been commited yet, but I think it is safe to assume they will).

On the other hand, when a completely new report is submitted, please put it where it looks more logical. For example keep report about drivers together, report about compilers together... In the next report we will have a valgrind and a gcc report in the Ports section: since valgrind can be used to debug software compiled with gcc, I think it makes sense to have them together.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants