Skip to content

Commit

Permalink
Add a comment noting that the additional range checks are not needed.
Browse files Browse the repository at this point in the history
The object size is set in the dsp_mmap_single() which provides the
range limit by vm_fault().

Reported by:	C Turt <ecturt@gmail.com>
Reviewed by:	alc, markj
admbug:		781
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation
  • Loading branch information
kostikbel committed Dec 2, 2018
1 parent ea0a5b7 commit 311df7e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion sys/dev/sound/pcm/dsp.c
Expand Up @@ -2205,7 +2205,10 @@ dsp_mmap(struct cdev *i_dev, vm_ooffset_t offset, vm_paddr_t *paddr,
int nprot, vm_memattr_t *memattr)
{

/* XXX memattr is not honored */
/*
* offset is in range due to checks in dsp_mmap_single().
* XXX memattr is not honored.
*/
*paddr = vtophys(offset);
return (0);
}
Expand Down

0 comments on commit 311df7e

Please sign in to comment.