Skip to content

Commit

Permalink
Update the pkg-stage target to be more compatible with pkg-1.2:
Browse files Browse the repository at this point in the history
 - Add a release-dvd.conf pkg(8) configuration file to override
   the default FreeBSD.conf configuration.
 - Remove architecture-specific pkg-stage.conf files, consolidate,
   and move their contents to scripts/pkg-stage.sh.
 - Use 'pkg -vv' to determine the ABI, which is used as the
   cache directory.

Prior to these changes, it would be possible for pkg-stage to fetch
conflicting binary packages from multiple repositories.

Tested against:	head@r260522, stable/10@r260522

MFC after:	3 days
X-Insta-MFC:	possibly
Sponsored by:	The FreeBSD Foundation
  • Loading branch information
Glen Barber authored and Glen Barber committed Jan 16, 2014
1 parent 5f171f6 commit 6f50c4e
Show file tree
Hide file tree
Showing 5 changed files with 41 additions and 93 deletions.
6 changes: 3 additions & 3 deletions release/Makefile
Expand Up @@ -224,9 +224,9 @@ packagesystem: base.txz kernel.txz ${EXTRA_PACKAGES}
touch ${.TARGET}

pkg-stage:
.if !defined(NOPKG) && exists(${.CURDIR}/${TARGET}/pkg-stage.conf)
sh ${.CURDIR}/scripts/pkg-stage.sh ${.CURDIR}/${TARGET}/pkg-stage.conf \
${REVISION}
.if !defined(NOPKG)
env REPOS_DIR=${.CURDIR}/pkg_repos/ \
sh ${.CURDIR}/scripts/pkg-stage.sh
mkdir -p ${.OBJDIR}/dvd/packages/repos/
cp ${.CURDIR}/scripts/FreeBSD_install_cdrom.conf \
${.OBJDIR}/dvd/packages/repos/
Expand Down
36 changes: 0 additions & 36 deletions release/amd64/pkg-stage.conf

This file was deleted.

36 changes: 0 additions & 36 deletions release/i386/pkg-stage.conf

This file was deleted.

8 changes: 8 additions & 0 deletions release/pkg_repos/release-dvd.conf
@@ -0,0 +1,8 @@
# $FreeBSD$
release: {
url: "pkg+http://pkg.FreeBSD.org/${ABI}/latest",
mirror_type: "srv",
signature_type: "fingerprints",
fingerprints: "/usr/share/keys/pkg",
enabled: yes
}
48 changes: 30 additions & 18 deletions release/scripts/pkg-stage.sh
Expand Up @@ -5,24 +5,31 @@

set -e

usage() {
echo "$(basename ${0}) /path/to/pkg-stage.conf revision"
exit 1
}

if [ ! -e "${1}" ]; then
echo "Configuration file not specified."
echo
usage
fi

if [ "$#" -lt 2 ]; then
usage
fi

# Source config file for this architecture.
REVISION="${2}"
. "${1}" || exit 1
export ASSUME_ALWAYS_YES=1
export PKG_DBDIR="/tmp/pkg"
export PERMISSIVE="YES"
export REPO_AUTOUPDATE="NO"
export PKGCMD="/usr/sbin/pkg -d"

DVD_PACKAGES="archivers/unzip
devel/subversion
devel/subversion-static
emulators/linux_base-f10
misc/freebsd-doc-all
net/mpd5
net/rsync
ports-mgmt/pkg
ports-mgmt/portmaster
shells/bash
shells/zsh
security/sudo
sysutils/screen
www/firefox
www/links
x11-drivers/xf86-video-vmware
x11/gnome2
x11/kde4
x11/xorg"

# If NOPORTS is set for the release, do not attempt to build pkg(8).
if [ ! -f /usr/ports/Makefile ]; then
Expand All @@ -33,8 +40,13 @@ if [ ! -x /usr/local/sbin/pkg ]; then
/usr/bin/make -C /usr/ports/ports-mgmt/pkg install clean
fi

export PKG_ABI=$(pkg -vv | grep ^ABI | awk '{print $3}')
export PKG_CACHEDIR="dvd/packages/${PKG_ABI}"

/bin/mkdir -p ${PKG_CACHEDIR}

# Print pkg(8) information to make debugging easier.
${PKGCMD} -vv
${PKGCMD} update -f
${PKGCMD} fetch -d ${DVD_PACKAGES}

Expand Down

0 comments on commit 6f50c4e

Please sign in to comment.