Skip to content

Commit

Permalink
e1000: disable TSO on lem(4) and em(4)
Browse files Browse the repository at this point in the history
Disable TSO on lem(4) and em(4) until a ring stall can be debugged.

I am not able to reproduce the issue on lem(4) but disabling there in
abundance of caution in case the issue is not specific to em(4).

Reported by:	grog
  • Loading branch information
kev009 committed Aug 15, 2023
1 parent 33469f1 commit 797e480
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions sys/dev/e1000/if_em.c
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,9 @@ em_if_attach_pre(if_ctx_t ctx)
scctx->isc_tx_csum_flags = CSUM_TCP | CSUM_UDP | CSUM_IP_TSO |
CSUM_IP6_TCP | CSUM_IP6_UDP;

/* Disable TSO on all em(4) until ring stalls can be debugged */
scctx->isc_capenable &= ~IFCAP_TSO;

/*
* Disable TSO on SPT due to errata that downclocks DMA performance
* i218-i219 Specification Update 1.5.4.5
Expand Down Expand Up @@ -938,6 +941,9 @@ em_if_attach_pre(if_ctx_t ctx)
scctx->isc_tx_csum_flags = CSUM_TCP | CSUM_UDP | CSUM_IP_TSO |
CSUM_IP6_TCP | CSUM_IP6_UDP;

/* Disable TSO on all lem(4) until ring stalls can be debugged */
scctx->isc_capenable &= ~IFCAP_TSO;

/* 82541ER doesn't do HW tagging */
if (hw->device_id == E1000_DEV_ID_82541ER ||
hw->device_id == E1000_DEV_ID_82541ER_LOM) {
Expand Down

0 comments on commit 797e480

Please sign in to comment.