Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less: Do not trust st_size if it equals zero #1004

Closed
wants to merge 1 commit into from

Conversation

ricardobranco777
Copy link
Contributor

@ricardobranco777 ricardobranco777 commented Jan 5, 2024

Fix for less(1) not being to operate on files residing in pseudo-filesystems that advertize a zero size value.

Bug: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276133

@igalic
Copy link
Contributor

igalic commented Jan 16, 2024

We usually want contrib to be merged upstream first.

@ricardobranco777
Copy link
Contributor Author

We usually want contrib to be merged upstream first.

Fix merged upstream: gwsw/less#468

@igalic
Copy link
Contributor

igalic commented Jan 22, 2024

Thank you for tracking this, @ricardobranco777

as soon as they make a new release, we'll import it into our vendor/less branch: https://cgit.freebsd.org/src/log/?h=vendor/less

@emaste
Copy link
Member

emaste commented Apr 19, 2024

CC @delphij

@bsdimp
Copy link
Member

bsdimp commented Apr 19, 2024

Specifically, should we import, or just cherry-pick the patch...

@bsdimp
Copy link
Member

bsdimp commented Apr 23, 2024

This isn't in v643, but is in v653 (gwsw/less@1fafd96 shows it there), but isn't in the release notes. v653 is in beta testing right now, so once it's official, @delphij will important it and we'll close this... Reading the tea leaves suggests this will be soon enough that cherry-picking the change isn't needed, but I'll reevaluate next time I do a deep scrub of the PRs (just before BSDcan most likely).

@delphij delphij self-assigned this Apr 23, 2024
@delphij
Copy link
Member

delphij commented Apr 23, 2024

Thanks for the PR. I'll commit this to vendor branch and merge this one. git will be able to handle it properly for future imports.

@bsdimp bsdimp added the ready label Apr 23, 2024
@delphij
Copy link
Member

delphij commented Apr 24, 2024

Merged as cae3362

@delphij delphij closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants