Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gjournal(8) unify capitalization #1017

Closed
wants to merge 1 commit into from

Conversation

PhantomDestrier
Copy link

Change "Journal" to "journal" in the first paragraph of Description to unify capitalization.

Event: Advanced UNIX Programming Course (Fall'23) at NTHU

Change "Journal" to "journal" in the first paragraph of Description to unify capitalization.

Event: Advanced UNIX Programming Course (Fall'23) at NTHU
Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the period at the end of the commit subject should be removed

otherwise: ✅

@PhantomDestrier PhantomDestrier changed the title gjournal(8) unify capitalization. gjournal(8) unify capitalization Jan 9, 2024
@PhantomDestrier
Copy link
Author

Fixed. Thanks for your comment.

@igalic
Copy link
Contributor

igalic commented Jan 9, 2024

Fixed. Thanks for your comment.

you removed it from the Pull Request, not from the commit message

but maybe that's something a committer can do for you, when they merge your patch

freebsd-git pushed a commit that referenced this pull request Feb 13, 2024
Event:		Advanced UNIX Programming Course (Fall'23) at NTHU
Pull Request:	#1017
@lwhsu
Copy link
Member

lwhsu commented Feb 13, 2024

Merged as 1d479bf

@lwhsu lwhsu closed this Feb 13, 2024
@lwhsu lwhsu added the merged label Feb 13, 2024
5u623l20 pushed a commit to 5u623l20/freebsd-src that referenced this pull request Feb 16, 2024
Event:		Advanced UNIX Programming Course (Fall'23) at NTHU
Pull Request:	freebsd#1017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants