Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore: Fix typo in veriexec man page #1018

Closed
wants to merge 1 commit into from
Closed

Conversation

hsuan1117
Copy link
Contributor

Name: Jui-Hsuan Chang
Email: hsuan1117@gapp.nthu.edu.tw

Typos corrected:
derrives -> derives

This is from the Advanced UNIX Programming Course (Fall’23) at NTHU.

Copy link
Contributor

@rilysh rilysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should add a message (the course) in your commit.
e.g.

veriexec(8): Fix typo in man page

Event: Advanced UNIX Programming Course (Fall’23) at NTHU.

See #951 (comment)

@hsuan1117
Copy link
Contributor Author

Hello @rilysh , I have just modified my commit message, plz take a look.
Thanks a lot !

@hsuan1117 hsuan1117 requested a review from rilysh January 9, 2024 17:19
Copy link
Contributor

@rilysh rilysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@igalic
Copy link
Contributor

igalic commented Jan 9, 2024

n.b.: your commit meta data does not match up with what you'd like it to be:

Name: Jui-Hsuan Chang
Email: hsuan1117@gapp.nthu.edu.tw

vs,

From: Hsuan <34859514+hsuan1117@users.noreply.github.com>

see, https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address

you need to set the commit email in your git cli, then go back rewrite the author: https://stackoverflow.com/questions/750172/how-do-i-change-the-author-and-committer-name-email-for-multiple-commits#1320317

Event: Advanced UNIX Programming Course (Fall’23) at NTHU.
@hsuan1117
Copy link
Contributor Author

@igalic I have modified the author name, thanks for reminding.

Copy link
Contributor

@igalic igalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

freebsd-git pushed a commit that referenced this pull request Feb 13, 2024
Event:		Advanced UNIX Programming Course (Fall’23) at NTHU.
Pull Request:	#1018
@lwhsu
Copy link
Member

lwhsu commented Feb 13, 2024

Merged as c8e7649

@lwhsu lwhsu closed this Feb 13, 2024
@lwhsu lwhsu added the merged label Feb 13, 2024
5u623l20 pushed a commit to 5u623l20/freebsd-src that referenced this pull request Feb 16, 2024
Event:		Advanced UNIX Programming Course (Fall’23) at NTHU.
Pull Request:	freebsd#1018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants