-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore: Fix typo in veriexec man page #1018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should add a message (the course) in your commit.
e.g.
veriexec(8): Fix typo in man page
Event: Advanced UNIX Programming Course (Fall’23) at NTHU.
See #951 (comment)
Hello @rilysh , I have just modified my commit message, plz take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
n.b.: your commit meta data does not match up with what you'd like it to be:
vs,
you need to set the commit email in your git cli, then go back rewrite the author: https://stackoverflow.com/questions/750172/how-do-i-change-the-author-and-committer-name-email-for-multiple-commits#1320317 |
Event: Advanced UNIX Programming Course (Fall’23) at NTHU.
@igalic I have modified the author name, thanks for reminding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Event: Advanced UNIX Programming Course (Fall’23) at NTHU. Pull Request: #1018
Merged as c8e7649 |
Event: Advanced UNIX Programming Course (Fall’23) at NTHU. Pull Request: freebsd#1018
Name: Jui-Hsuan Chang
Email: hsuan1117@gapp.nthu.edu.tw
Typos corrected:
derrives -> derives
This is from the Advanced UNIX Programming Course (Fall’23) at NTHU.