fix - fix cp_typo #1033
Closed
fix - fix cp_typo #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwhsu
approved these changes
Jan 15, 2024
- line 343 for correct path -> for the correct path concatenation - line 430 optimise -> optimize - Event: Advanced UNIX programming course (Fall'23) at NTHU
chiajungchang2003
force-pushed
the
cp_typo
branch
from
0edef31
to
3d8da80
Compare
|
Optimise is fine as it's British spelling. |
freebsd-git
pushed a commit
that referenced
this pull request
Feb 13, 2024
Event: Advanced UNIX programming course (Fall'23) at NTHU Pull Request: #1033
|
Merged as 416fdc2 |
5u623l20
pushed a commit
to 5u623l20/freebsd-src
that referenced
this pull request
Feb 16, 2024
Event: Advanced UNIX programming course (Fall'23) at NTHU Pull Request: freebsd#1033
|
A bit late but “for correct path concatenation” was also correct. If you want to add an article you'll also have to invert the (nouned) verb and object, e.g. “for the correct concatenation of paths”, and even then the article is optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event: Advanced UNIX programming course (Fall'23) at NTHU