ctags: Use C99 bool instead of defining our own #1107
Conversation
|
Two of the style(9) failures are from the weird GETC macro. The others are because I did not add previously missing parentheses around return values. Should I amend or leave it for a different patch? |
|
I'd match the existing style, so don't change the returns. |
|
I think this is ready. I'll try to land it later today. |
| @@ -48,7 +48,7 @@ PF_funcs(void) | |||
| char *cp; | |||
| char tok[MAXTOKEN]; | |||
|
|
|||
| for (pfcnt = NO;;) { | |||
| for (pfcnt = false;;) { | |||
There was a problem hiding this comment.
Should int PF_funcs(void) be changed to bool PF_funcs(void) due to these changes?
There was a problem hiding this comment.
I think so because we're return pfcnt 3 lines below.
There was a problem hiding this comment.
Thanks for checking, you are right. While fixing it I also noticed that "skip_key" in C.c and ctags.h should return bool. I'll amend those changes to the commit.
Use stdbool.h definitions instead of defining non-standard ones. Signed-off-by: Collin Funk <collin.funk1@gmail.com>
collinfunk
force-pushed
the
ctags-stdbool
branch
from
7c4113d
to
c383fab
Compare
|
That should be all of them hopefully... |
Use stdbool.h definitions instead of defining non-standard ones. Signed-off-by: Collin Funk <collin.funk1@gmail.com> Reviewed by: markj MFC after: 2 weeks Pull Request: #1107
|
Merged. |
Use stdbool.h definitions instead of defining non-standard ones.