Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cp: Remove useless ssize_t cast #1116

Closed
wants to merge 1 commit into from

Conversation

collinfunk
Copy link
Contributor

Both wcount and wresid are ssize_t so this cast is not needed. Just remove it so the code is easier to read.

Both wcount and wresid are ssize_t so this cast is not needed. Just
remove it so the code is easier to read.

Signed-off-by: Collin Funk <collin.funk1@gmail.com>
Copy link
Contributor

@gmshake gmshake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

freebsd-git pushed a commit that referenced this pull request Mar 21, 2024
Both wcount and wresid are ssize_t so this cast is not needed. Just
remove it so the code is easier to read.

Signed-off-by:	Collin Funk <collin.funk1@gmail.com>
Reviewed by:	emaste, zlei
Pull Request:	#1116
@markjdb markjdb added the merged label Apr 5, 2024
@markjdb
Copy link
Member

markjdb commented Apr 5, 2024

Landed in 8b86415

@markjdb markjdb closed this Apr 5, 2024
@collinfunk collinfunk deleted the cp-useless-cast branch April 8, 2024 12:08
freebsd-git pushed a commit that referenced this pull request Apr 18, 2024
Both wcount and wresid are ssize_t so this cast is not needed. Just
remove it so the code is easier to read.

Signed-off-by:	Collin Funk <collin.funk1@gmail.com>
Reviewed by:	emaste, zlei
Pull Request:	#1116

(cherry picked from commit 8b86415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants