usb: Fix and cleanup quirks list #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm struggling with how to review this. |
|
I separated the changes into two commits: A large part of the changes are in the second commit, not sure I can separate them though. Edit: Also fix some > 80 character warnings |
|
the latest changes look like they can be reviewed, so I'll go over them with a fine toothed comb to see if anything stands out. |
In some cases, the USB_QUIRK_VP macro was being misused. Instead of setting quirks to the intended value, the first two supplied quirks would go into lo_rev and hi_rev. Replace it with USB_QUIRK_VO which only takes the needed args. This also makes the Dummy products, which where being used to correctly set vendor only quirks, not necessary. Reviewed by: imp Pull Request: freebsd#1153
Seperate usb quirks that target specific revisions from those that dont. Alot of the quirks dont use lo_rev and hi_rev, so we can abstract the 0x0000, 0xffff into a macro. [[ This commit is a bit more churn than we like. I carefully reviewed each one and they are all good. The end product is better -- imp ]] Reviewed by: imp Pull Request: freebsd#1153
|
That's new :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
USB_QUIRK_VPmacro was being misused in the usb_quirks list, e.gUSB_QUIRK_VP(USB_VENDOR_MPMAN, 0, UQ_MSC_NO_SYNC_CACHE, UQ_MATCH_VENDOR_ONLY)would set lo_res and hi_res to the first two specified quirks.I've replaced it with a new macro,
USB_QUIRK_VO, which removes the unneeded verbosity. Having this macro also removes the need for the dummy products used to specify vendor only quirks.I also separated the usb quirks that target specific revisions from those that dont. A lot of the quirks dont use
lo_rev and hi_rev, so we can abstract the 0x0000, 0xffff into a macro.
Edit: Forgot to mention that I also replaced a
|with,. Looks like it was left over from eb58441https://github.com/freebsd/freebsd-src/blob/main/sys/dev/usb/quirk/usb_quirk.c#L335