Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Intel Atom S1200 UART #1164

Closed
wants to merge 1 commit into from

Conversation

hhartzer
Copy link
Contributor

PR: 278316

Signed-off-by: Henrich Hartzer henrichhartzer@tuta.io

PR: 278316

Signed-off-by: Henrich Hartzer <henrichhartzer@tuta.io>
@hhartzer
Copy link
Contributor Author

This did not work until I disabled MSI. If this looks good, I would appreciate it if it could be backported to stable/14.

Thank you!

@bsdimp
Copy link
Member

bsdimp commented Apr 12, 2024

Ideally, we'd want to know WHY it didn't work with MSI enabled. Did you discover any erratum or other basis for disabling msi?

@hhartzer
Copy link
Contributor Author

It just didn't work for me with MSI enabled. I could either disable MSI or set debug.uart_force_poll to 1 to get it going. There were no BIOS options around this.

I imagine this isn't going to be used very commonly. I do think it's not going to hurt much, performance wise, for the typical applications to not use MSI.

There is only one other driver in there that doesn't use MSI.

I do agree that ideally this would be better understood, and if someone else has the same kind of hardware I'd encourage them to test and I'd be happy to check patches on my hardware as well. I've already put several hours into this, (largely because I've never worked around this before) so I'd prefer not to test a whole lot other permutations unless they're straight forward.

@bsdimp bsdimp self-assigned this Apr 19, 2024
@bsdimp bsdimp added the ready label Apr 19, 2024
@bsdimp
Copy link
Member

bsdimp commented Apr 19, 2024

Great! Wished for better, but that's enough

freebsd-git pushed a commit that referenced this pull request Apr 19, 2024
PR: 278316

Signed-off-by: Henrich Hartzer <henrichhartzer@tuta.io>
Reviewed by: imp
Pull Request: #1164
@bsdimp
Copy link
Member

bsdimp commented Apr 19, 2024

Thanks for the explanation and contribution. Landed.

@bsdimp bsdimp closed this Apr 19, 2024
@bsdimp bsdimp added merged and removed ready labels Apr 19, 2024
@hhartzer
Copy link
Contributor Author

Thank you so much!! I appreciate you merging this!

Might it be possible to backport this to stable/14? It'd be nice if I could use it in 14.1, when it comes in a few months, without recompiling.

@hhartzer hhartzer deleted the atom-s1200-uart branch April 20, 2024 00:38
@bsdimp
Copy link
Member

bsdimp commented Apr 20, 2024

Queued to my mfc queue. I'll push it in Monday or Tuesday.

freebsd-git pushed a commit that referenced this pull request Apr 25, 2024
PR: 278316

Signed-off-by: Henrich Hartzer <henrichhartzer@tuta.io>
Reviewed by: imp
Pull Request: #1164
(cherry picked from commit 1f2776e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants