rescue: add ipfw, pfctl #1169
Closed
rescue: add ipfw, pfctl #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale for this change: - ipf is already there - if the kernel is configured with a packet filter which drops packets by default, pfctl or ipfw will be required in the rescue environment to make the network functional. - rescue's stated purpose is to be useful for small/embedded systems (and is also quite useful for small jails); a rescue-based router would want these binaries. On amd64, this increases the size of rescue from 17346200 to 17907248, or 561048 bytes (3.2%).
|
edit: this is done |
|
Size increase seems reasonable and anyone who needs an especially small image can build with only one of pf/ipf/ipfw. |
|
merged. thanks for the cleanup |
freebsd-git
pushed a commit
that referenced
this pull request
Apr 19, 2024
Rationale for this change: - ipf is already there - if the kernel is configured with a packet filter which drops packets by default, pfctl or ipfw will be required in the rescue environment to make the network functional. - rescue's stated purpose is to be useful for small/embedded systems (and is also quite useful for small jails); a rescue-based router would want these binaries. On amd64, this increases the size of rescue from 17346200 to 17907248, or 561048 bytes (3.2%). Reviewed by: imp Pull Request: #1169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change:
ipf is already there
if the kernel is configured with a packet filter which drops packets by default, pfctl or ipfw will be required in the rescue environment to make the network functional.
rescue's stated purpose is to be useful for small/embedded systems (and is also quite useful for small jails); a rescue-based router would want these binaries.
On amd64, this increases the size of rescue from 17346200 to 17907248, or 561048 bytes (3.2%).