New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make usr/share/examples more packagey #1176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is all happening in the same file, so i don't think it's necessary to split anything.
Just do them all in one go. (and i mean all, not just three three)
i'm happy to squash them but i prefer not to do this initially because it makes it difficult to merge into my local branch (which i run in production). if this passes review / is okay to commit i can squash it, just lmk. |
Allow a new variable SE_xxxPACKAGE to be used to place an example group into a package. Move the following examples into existing appropriate packages: - bhyve examples into FreeBSD-bhyve - bootforth examples into FreeBSD-bootloader - csh examples into FreeBSD-csh - ipfw examples into FreeBSD-ipfw - jail examples into FreeBSD-jail - pf examples into FreeBSD-pf - ppp examples into FreeBSD-ppp - printing examples into FreeBSD-lp - uefisign examples into FreeBSD-efi-tools - ypldap examples into FreeBSD-yp - hast examples into FreeBSD-hast Move all other examples into the new 'FreeBSD-examples' package. This removes a significant number of files from the FreeBSD-utilities package.
ad846c7
to
8402a0f
Compare
|
I think it's good. We will have the examples in the right package and if no matching package is present it will be in the FreeBSD-examples packages. |
i think this means: "i approve". |
Looks good... Last call... |
Allow a new variable SE_xxxPACKAGE to be used to place an example group into a package. Move the following examples into existing appropriate packages: - bhyve examples into FreeBSD-bhyve - bootforth examples into FreeBSD-bootloader - csh examples into FreeBSD-csh - ipfw examples into FreeBSD-ipfw - jail examples into FreeBSD-jail - pf examples into FreeBSD-pf - ppp examples into FreeBSD-ppp - printing examples into FreeBSD-lp - uefisign examples into FreeBSD-efi-tools - ypldap examples into FreeBSD-yp - hast examples into FreeBSD-hast Move all other examples into the new 'FreeBSD-examples' package. This removes a significant number of files from the FreeBSD-utilities package. Reviewed by: imp, manu Pull Request: #1176
merged |
3 commits here: 1 adds the Makefile soup to allow examples to live in packages, and two commits move the pf and HAST examples to their proper home.
i can do more commits for the rest of the examples, but i wanted to check the basic idea is sound first.
cc: @evadot, @bapt, @igalic