add dtb support for RPI CM4, CM4s, CM4_ioBoard #1182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks reasonable, thank you for this. Can you please include a Signed-off-by: trailer in the commit, certifying agreement with https://developercertificate.org/. |
Signed-off-by: Klaus Küchemann <maciphone2@googlemail.com>
|
|
merged. thanks for the contribution... the other rpi one is waiting on ed making contact with the broadcom linux kernel engineer, if possible... |
freebsd-git
pushed a commit
that referenced
this pull request
Apr 19, 2024
Signed-off-by: Klaus Küchemann <maciphone2@googlemail.com> Reviewed by: imp Pull Request: #1182
|
Should i revert until Ed can land #1179? |
|
perhaps better reverting (only if Ed thinks it could last a bit longer to land #1179) . |
|
but perhaps prefer to land #1179 now ,… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the test of PR #1179 was successful
it should make sense to support these models.
That wasn't possible before because cm4-models crashed by pcie devmatch .
While in my tests I had manually added only bcm2711-rpi-cm4.dtb to config.txt
without the corresponding bcm2711-rpi-cm4-io.dtb for the io-board,
I presume there normally should be no caveats with bcm2711-rpi-cm4-io.dtb .