Fix CTL GET EVENT STATUS NOTIFICATION valid bits #1201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdimp
reviewed
Apr 26, 2024
|
So this one was fun to track down... Glad I spent a fair amount of time downloading the scsi specs ages ago... gotta go look for mmc5 and mmc6 it turns out... |
hpvb
force-pushed
the
fix-ctl-gevsn-params
branch
from
3112c78
to
0d90873
Compare
|
I've adjusted the PR based on your input. |
|
@hpvb I'm sorry, but I don't see the changes. |
hpvb
force-pushed
the
fix-ctl-gevsn-params
branch
from
0d90873
to
536444f
Compare
I forgot at git add the file when I amended the commit. Sorry! Fixed. |
bsdimp
reviewed
Apr 26, 2024
| @@ -1227,7 +1227,7 @@ const struct ctl_cmd_entry ctl_cmd_table[256] = | |||
| CTL_CMD_FLAG_ALLOW_ON_PR_RESV | | |||
| CTL_FLAG_DATA_IN, | |||
| CTL_LUN_PAT_NONE, | |||
| 10, {0x02, 0x01, 0, 0, 0, 0xff, 0xff, 0xff, 0x07}}, | |||
| 10, {0xe1, 0, 0, 0x7e, 0, 0x0, 0xff, 0xff, 0xc7}}, | |||
|
|
|||
There was a problem hiding this comment.
This style checker message is a bit too zealous.
bsdimp
approved these changes
Apr 26, 2024
amotin
reviewed
Apr 26, 2024
hpvb
force-pushed
the
fix-ctl-gevsn-params
branch
from
536444f
to
7902ae1
Compare
Linux as an initiator periodically sends the following to SCSI cdrom devices: 4a 01 00 00 10 00 00 00 08 00 According to the ctl_cmd_entry for this command this is invalid which leads to a lot of failed SCSI commands. The mask in this commit is based off of the t10 spec available here: https://www.t10.org/ftp/t10/document.97/97-108r0.pdf And @bsdimp's research. This solves the issue with Linux initiators. Signed-off-by: HP van Braam <hp@tmm.cx>
hpvb
force-pushed
the
fix-ctl-gevsn-params
branch
from
7902ae1
to
aa9d49d
Compare
amotin
approved these changes
Apr 26, 2024
|
Landed with tweaked commit message to spell out what my research is / was. |
freebsd-git
pushed a commit
that referenced
this pull request
Apr 29, 2024
Linux as an initiator periodically sends the following to SCSI cdrom devices: 4a 01 00 00 10 00 00 00 08 00 According to the ctl_cmd_entry for this command this is invalid which leads to a lot of failed SCSI commands. The mask in this commit is based off of an early draft of the mmc standard, https://www.t10.org/ftp/t10/document.97/97-108r0.pdf, as well as subsequent standards (mmc2 through mmc6). This solves the issue with Linux initiators. Signed-off-by: HP van Braam <hp@tmm.cx> Reviewed by: imp, mav Pull Request: #1201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux as an initiator periodically sends the following to SCSI cdrom devices: 4a 01 00 00 10 00 00 00 08 00
According to the ctl_cmd_entry for this command this is invalid which leads to a lot of failed SCSI commands.
The mask in this commit is based off of the t10 spec available here: https://www.t10.org/ftp/t10/document.97/97-108r0.pdf
And @bsdimp's research.
This solves the issue with Linux initiators.