Remove COMPAT_FREEBSD4/5/6/7/9 from MINIMAL and FIRECRACKER kernel configurations #1228
Conversation
|
left a comment in the bug, but basically "think it's a great idea, but we should run this by arch@, I don't think anybody will object. Proactively state this won't affect rust and it should be smooth sailing" |
|
In an ideal world, we'd have the compat stuff be an autoload, but there's a few places where it's not just wrapping the older ABI to call the new APIs. |
There was a problem hiding this comment.
The MINIMAL configuration for i386 also features compatibility back to FreeBSD 4.
PowerPC also features compatibility back to FreeBSD 6 in its GENERIC, GENERIC64 and MPC85XXSPE configurations.
Overall seems reasonable to me. Just need to make sure not to miss anything.
hhartzer
force-pushed
the
disable-compat-freebsd-4-5-6-7-9
branch
from
0c40e28
to
576cf6b
Compare
|
Good catch on those ones I missed. The old Phabricator review had a couple others as well. Should be addressed now. I've emailed arch@ about this topic. |
|
My sense of the arch@ thread is that there's not a lot of support for this. |
|
Yeah, I think you're right. I probably shouldn't have mentioned deleting these, although I'm really surprised there's such pushback on this. This isn't something like C89, C99, POSIX, etc. Just very end-of-lifed FreeBSD ABI support. Do you think the changes in MINIMAL might be acceptable? And possibly FIRECRACKER? |
|
It's worth talking to @cperciva about FIRECRACKER, but it's hard to imagine that any compat options beyond those required for rust/go support are needed there. Likewise I think removing from MINIMAL makes sense. |
Rust is 12+ rust-lang/rust#89058 |
|
I'm ok with removing these from the FIRECRACKER kernel. |
|
It's my read of the arch@ thread that there's no community support for removing these from GENERIC, so please drop that part of this change. |
hhartzer
force-pushed
the
disable-compat-freebsd-4-5-6-7-9
branch
from
576cf6b
to
69e6e05
Compare
hhartzer
changed the title
|
Should be ready for re-review. |
…nfigurations FIRECRACKER is not a legacy config, so remove the really old FreeBSD versions from it. MINIMAL has a similar history, and limited target audience which has little to no overlap with really old binaries. Either of these is really easy to get additional binary compat with the include directive, so balance things better. Leave GENERIC alone. PR: 231768 Signed-off-by: Henrich Hartzer <henrichhartzer@tuta.io> Reviewed by: imp (MINIMAL), cperciva (FIRECRACKER) Pull Request: freebsd#1228
bsdimp
force-pushed
the
disable-compat-freebsd-4-5-6-7-9
branch
from
69e6e05
to
87bf0aa
Compare
PR: 231768