bhyve: avoid side effect in assertion #1244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An assert() was setting the error variable instead of checking it. Reported by: Coverity Scan CID: 1521431 Sponsored by: The FreeBSD Foundation
bsdjhb
approved these changes
May 17, 2024
freebsd-git
pushed a commit
that referenced
this pull request
May 17, 2024
An assert() was setting the error variable instead of checking it. Reported by: Coverity Scan CID: 1521431 Reviewed by: jhb Sponsored by: The FreeBSD Foundation Pull Request: #1244
|
Yea. I wish we could push this to the submitter's branch to get this marked as merged... but so far all my attempts to do this after git-freebsd push have failed on other pull requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assert() was setting the error variable instead of checking it.
Reported by: Coverity Scan
CID: 1521431
Sponsored by: The FreeBSD Foundation