improve LINT-NOINET{6,} #1255
Merged
improve LINT-NOINET{6,} #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsdimp
approved these changes
May 24, 2024
Reviewed by: imp Pull Request: freebsd#1255
Previously, it was necessary to set WITHOUT_INET_SUPPORT when building the kernel without INET, and WITHOUT_INET6_SUPPORT when building the kernel without INET6, or else the modules build would fail. The LINT-NOINET and LINT-NOINET6 configs did this using makeoptions. After recent changes, this is no longer required, so remove these makeoptions. This avoids masking potential future build issues when these aren't set. Reviewed by: imp Pull Request: freebsd#1255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also includes a required fix for the ipfw module after this change.
tested both kernel configs with buildkernel on amd64.