Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated lines in contrib/tzcode/stdtime/private.h #154

Closed
wants to merge 1 commit into from

Conversation

timClicks
Copy link
Contributor

This pull request eliminates some duplication in the source.

Copy link
Contributor

@ngie-eign ngie-eign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good to merge. I don't see it in the upstream version of tzcode: https://github.com/valodzka/tzcode/blob/master/private.h#L204 .

@emaste: is there anything that needs to be done to merge this change?

freebsd-git pushed a commit that referenced this pull request May 31, 2021
Note by imp: this is clearly a mis-merge from the vendor branch which
doesn't have this stutter in it.

Reviewed by:		imp@,ngie@
Pull Request:		#154
@bsdimp
Copy link
Member

bsdimp commented May 31, 2021

d912068 in main pulls this in, closing out this pull request.
For the record: it looks like this was a mis-merge from the vendor branch somewhere along the way.
The 'somewhere' is so far back I can't find it more specifically than the import of 2009e.
So removing this in -current won't affect future vendor merges.

@bsdimp bsdimp closed this May 31, 2021
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this pull request Dec 9, 2021
Note by imp: this is clearly a mis-merge from the vendor branch which
doesn't have this stutter in it.

Reviewed by:		imp@,ngie@
Pull Request:		freebsd/freebsd-src#154
@emaste emaste added the merged label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants